Add a newline at the end of a gzipped tsv file #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kazjote! Will get this scheduled for the next release. |
|
Hi, i upgraded our kinesis-s3 sink from 0.4.0 to 0.4.1 and i had to backport this PR, as it didn't make it upstream. Is this still scheduled? |
|
This is important - bringing forwards... |
|
Do you think this could be released as a 0.4.2 bugfix release? |
|
@christoph-buente It will be part of 0.5.0 which is currently in development (sorry for the delayed answer, didn't get an email somehow). |
BenFradet
changed the title
BenFradet
changed the title
BenFradet
pushed a commit
that referenced
this pull request
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing newline at the end of tsv file made spark not to read the last event from each file.