-
Notifications
You must be signed in to change notification settings - Fork 38
Add support for the Chinese Kinesis endpoint #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding the endpoint to support AWS China region.
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign. Once you've signed, please reply here (e.g. |
PR looks good, just waiting for the CLA to be signed. |
I signed it! |
Confirmed! @bobshaw1912 has signed the Individual Contributor License Agreement. Thanks so much. |
I signed it! On Sun, Oct 23, 2016 at 9:40 PM, Snowplow CLA bot [email protected]
|
I've signed the CLA and replied the email already. Anything else to do? Get Outlook for iOS On Tue, Oct 25, 2016 at 5:25 PM +0800, "Josh" [email protected] wrote: PR looks good, just waiting for the CLA to be signed. — |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , incorporating into #91
Adding the endpoint to support AWS China region.