Skip to content

Add support for the Chinese Kinesis endpoint #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bobshaw1912
Copy link
Contributor

Adding the endpoint to support AWS China region.

Adding the endpoint to support AWS China region.
@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@jbeemster
Copy link
Member

PR looks good, just waiting for the CLA to be signed.

@bobshaw1912
Copy link
Contributor Author

I signed it!

@snowplowcla
Copy link

Confirmed! @bobshaw1912 has signed the Individual Contributor License Agreement. Thanks so much.

@alexanderdean alexanderdean added this to the Version 0.5.0 milestone Oct 25, 2016
@bobshaw1912
Copy link
Contributor Author

I signed it!

On Sun, Oct 23, 2016 at 9:40 PM, Snowplow CLA bot [email protected]
wrote:

Thanks for your pull request. Is this your first contribution to a
Snowplow open source project? Before we can look at your pull request,
you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA
https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#71 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV8bjFUrMbr6ECe4HYpCpVC7JFuPn2OYks5q22O-gaJpZM4KeHnM
.

@bobshaw1912
Copy link
Contributor Author

I've signed the CLA and replied the email already. Anything else to do?

Get Outlook for iOS

On Tue, Oct 25, 2016 at 5:25 PM +0800, "Josh" [email protected] wrote:

PR looks good, just waiting for the CLA to be signed.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , incorporating into #91

@BenFradet BenFradet changed the title Add AWS China and Kinesis endpoint Add support for the Chinese Kinesis endpoint Jun 28, 2017
@BenFradet BenFradet closed this in cd7ec9b Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants