This repository was archived by the owner on Jan 7, 2022. It is now read-only.
Remove static ssa #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, it works. Ready. |
|
I always forget the tidy cheker ;) |
|
Please squash. |
vext01
force-pushed
the
remove-static-ssa
branch
from
eebdbd7 to
adbdacb
Compare
|
splat |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 26, 2019
17: Remove static ssa r=ltratt a=vext01 This kills the SSA code in the compiler (and switches the lib to Rust 2018). I'm just going to check if we can flip this over to using `yk`, so please don't merge just yet. Co-authored-by: Edd Barrett <[email protected]>
Build failed |
|
I forgot to remove back-out the TIR test change. |
|
This fixes the test. bors try |
tryBuild succeeded |
|
Please squash. |
In hindsight, we've decided we probably don't need TIR to be in SSA. Not all is lost. We have the algorithms in the Git history, so we can refer to it later if we need it (either at runtime, or compile time).
vext01
force-pushed
the
remove-static-ssa
branch
from
38897ae to
f3ad5c4
Compare
|
splat. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 29, 2019
17: Remove static ssa r=ltratt a=vext01 This kills the SSA code in the compiler (and switches the lib to Rust 2018). I'm just going to check if we can flip this over to using `yk`, so please don't merge just yet. Co-authored-by: Edd Barrett <[email protected]>
Build succeeded |
bors bot
pushed a commit
that referenced
this pull request
Sep 22, 2019
sync with rust-lang/rust master branch
vext01
pushed a commit
to vext01/ykrustc
that referenced
this pull request
Oct 12, 2020
This is a combination of 18 commits. Commit softdevteam#2: Additional examples and some small improvements. Commit softdevteam#3: fixed mir-opt non-mir extensions and spanview title elements Corrected a fairly recent assumption in runtest.rs that all MIR dump files end in .mir. (It was appending .mir to the graphviz .dot and spanview .html file names when generating blessed output files. That also left outdated files in the baseline alongside the files with the incorrect names, which I've now removed.) Updated spanview HTML title elements to match their content, replacing a hardcoded and incorrect name that was left in accidentally when originally submitted. Commit softdevteam#4: added more test examples also improved Makefiles with support for non-zero exit status and to force validation of tests unless a specific test overrides it with a specific comment. Commit softdevteam#5: Fixed rare issues after testing on real-world crate Commit softdevteam#6: Addressed PR feedback, and removed temporary -Zexperimental-coverage -Zinstrument-coverage once again supports the latest capabilities of LLVM instrprof coverage instrumentation. Also fixed a bug in spanview. Commit softdevteam#7: Fix closure handling, add tests for closures and inner items And cleaned up other tests for consistency, and to make it more clear where spans start/end by breaking up lines. Commit softdevteam#8: renamed "typical" test results "expected" Now that the `llvm-cov show` tests are improved to normally expect matching actuals, and to allow individual tests to override that expectation. Commit softdevteam#9: test coverage of inline generic struct function Commit softdevteam#10: Addressed review feedback * Removed unnecessary Unreachable filter. * Replaced a match wildcard with remining variants. * Added more comments to help clarify the role of successors() in the CFG traversal Commit softdevteam#11: refactoring based on feedback * refactored `fn coverage_spans()`. * changed the way I expand an empty coverage span to improve performance * fixed a typo that I had accidently left in, in visit.rs Commit softdevteam#12: Optimized use of SourceMap and SourceFile Commit softdevteam#13: Fixed a regression, and synched with upstream Some generated test file names changed due to some new change upstream. Commit softdevteam#14: Stripping out crate disambiguators from demangled names These can vary depending on the test platform. Commit softdevteam#15: Ignore llvm-cov show diff on test with generics, expand IO error message Tests with generics produce llvm-cov show results with demangled names that can include an unstable "crate disambiguator" (hex value). The value changes when run in the Rust CI Windows environment. I added a sed filter to strip them out (in a prior commit), but sed also appears to fail in the same environment. Until I can figure out a workaround, I'm just going to ignore this specific test result. I added a FIXME to follow up later, but it's not that critical. I also saw an error with Windows GNU, but the IO error did not specify a path for the directory or file that triggered the error. I updated the error messages to provide more info for next, time but also noticed some other tests with similar steps did not fail. Looks spurious. Commit softdevteam#16: Modify rust-demangler to strip disambiguators by default Commit softdevteam#17: Remove std::process::exit from coverage tests Due to Issue #77553, programs that call std::process::exit() do not generate coverage results on Windows MSVC. Commit softdevteam#18: fix: test file paths exceeding Windows max path len
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kills the SSA code in the compiler (and switches the lib to Rust 2018).
I'm just going to check if we can flip this over to using
yk, so please don't merge just yet.