react native wallet POC #152

zfurtak · 2024-12-13T13:07:33Z

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

modules/react-native-wallet/android/build.gradle

modules/react-native-wallet/android/src/main/AndroidManifest.xml

modules/react-native-wallet/android/src/main/java/com/wallet/WalletModule.kt

j-piasecki · 2024-12-13T15:30:54Z

modules/react-native-wallet/android/src/oldarch/WalletSpec.kt

+package com.wallet
+
+import com.facebook.react.bridge.ReactApplicationContext
+import com.facebook.react.bridge.ReactContextBaseJavaModule
+import com.facebook.react.bridge.Promise
+import com.facebook.react.bridge.ReadableMap
+
+abstract class WalletSpec internal constructor(context: ReactApplicationContext) :
+  ReactContextBaseJavaModule(context) {
+
+  abstract fun checkWalletAvailability(promise: Promise)
+  abstract fun getSecureWalletInfo(promise: Promise)
+  abstract fun getCardStatus(last4Digits: String, promise: Promise)
+  abstract fun getCardTokenStatus(tsp: String, tokenRefId: String, promise: Promise)
+  abstract fun addCardToWallet(cardData: ReadableMap, promise: Promise)
+}


This approach for compatibility with the old arch is fine, but you may also want to consider automatically copying the spec generated by codegen when there are any changes to the output. We already do it in other libraries: software-mansion/react-native-gesture-handler#3001.

This way you won't have to remember to update the paper spec each time you change the TS definition. You can also setup a github action to make sure every PR updates the java spec when needed.

modules/react-native-wallet/android/src/main/java/com/wallet/WalletPackage.kt

modules/react-native-wallet/example/src/App.tsx

j-piasecki · 2024-12-13T15:44:36Z

modules/react-native-wallet/ios/Wallet.mm

+
+// Example method
+// See // https://reactnative.dev/docs/native-modules-ios
+RCT_EXPORT_METHOD(multiply:(double)a


Ah, yes. The best thing you can do with a wallet - multiply 😄

modules/react-native-wallet/react-native-wallet.podspec

j-piasecki · 2024-12-13T15:53:19Z

modules/react-native-wallet/android/src/main/java/com/wallet/Utils.kt

+    getPromiseOperation: (Promise) -> Unit
+  ): String = withContext(Dispatchers.IO) {
+    suspendCancellableCoroutine { continuation ->
+      val promise = object : Promise {


Are you passing this promise to the JS side?

I haven't used coroutines that much (and it was a while ago), but isn't there some way to handle this using Kotlin primitives instead of doing native-only promise (unless I missed something).

modules/react-native-wallet/android/src/main/java/com/wallet/WalletModule.kt

zfurtak and others added 20 commits November 13, 2024 11:40

Created turbo module

15d362a

Added Google SDK dependencies

ab1d602

Moved to modules

098ffc1

Add yarn.lock

5d76211

POC functions

05a7448

Code refactor

626db63

Added getCardStatus function

1b531f9

Fix card provider values

0b2d899

Add error handling for invalid card network

3efc398

Update example app

c07be03

Change types export

b2f6444

Add card state handling

1a51b21

Fix getCardStatus function

1f16b8c

Add getCardStatus funciton to example app

5c5fcd6

Add get token status

ca3c40b

Add event listener functions

09d7aec

Remove code dupliactes

37c1275

Add onCardActivated listener

2f4de28

Fix launching the example app on new archotecture

822975c

Migrate yarn to npm

07b78c5

j-piasecki reviewed Dec 13, 2024

View reviewed changes

j-piasecki reviewed Dec 16, 2024

View reviewed changes

Skalakid and others added 4 commits December 19, 2024 10:21

Fix path after changing package name

2055f53

Removed unnecessary support for very old versions

e5c69e9

Refactored android methods

05149c5

Adjusted podspec and WalletPackage

e8f9578

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

react native wallet POC #152

react native wallet POC #152

zfurtak commented Dec 13, 2024

j-piasecki Dec 13, 2024

j-piasecki Dec 13, 2024

j-piasecki Dec 13, 2024

react native wallet POC #152

Are you sure you want to change the base?

react native wallet POC #152

Conversation

zfurtak commented Dec 13, 2024

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

j-piasecki Dec 13, 2024

Choose a reason for hiding this comment

j-piasecki Dec 13, 2024

Choose a reason for hiding this comment

j-piasecki Dec 13, 2024

Choose a reason for hiding this comment