Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually assign entries for voting #1097

Merged
merged 29 commits into from
Apr 6, 2024

Conversation

DesSnowy
Copy link
Contributor

Description

This change allows admin to control when they wish to assign / reassign entries for voting. Existing submission for the assessment will be deleted if voting was previously assigned. This enables better control of when voting assignment can be done.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Changes to be made:

  • Added new function reassign_voting to delete and reassign voting
  • Added new call to reassign_voting in assessment_controller
  • Added new function is_voting_assigned to check if voting is assigned for any of the questions in the assessment
  • Added isVotingPublished field in assessment overview output

DesSnowy added 27 commits March 20, 2024 23:39
…:DesSnowy/source-academy-backend into RenameHasTokenCounterToHasVotingFeatures
@DesSnowy
Copy link
Contributor Author

Corresponding frontend PR: source-academy/frontend#2889

@coveralls
Copy link

coveralls commented Mar 29, 2024

Coverage Status

coverage: 95.558% (+0.05%) from 95.508%
when pulling ef820f1 on DesSnowy:ControlOfInsertVoting
into 59fe997 on source-academy:master.

@DesSnowy DesSnowy requested a review from RichDom2185 March 29, 2024 15:39
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185 RichDom2185 merged commit 556f7ad into source-academy:master Apr 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants