Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Long dialog titles cause the generic dialog components to extend beyond the screen dimensions on mobile view #2241

Closed
ianyong opened this issue Oct 17, 2022 · 1 comment · Fixed by #2792
Closed

Mobile: Long dialog titles cause the generic dialog components to extend beyond the screen dimensions on mobile view #2241

ianyong opened this issue Oct 17, 2022 · 1 comment · Fixed by #2792
Assignees
@Johnwz123
Labels
Enhancement New feature request

Comments

@ianyong
Copy link
Member

ianyong commented Oct 17, 2022

The generic ConfirmDialog and PromptDialog components both suffer from this issue, which affects all existing dialogs where the title is fairly long.

image
@martin-henz martin-henz added the Enhancement New feature request label Dec 31, 2022
@Johnwz123
Copy link
Contributor

Johnwz123 commented Jan 28, 2024 •
edited
Loading

A similar issue can be observed for each of the assignment blocks, where the title, "Finalise Submission" and "Review Submission" cannot be seen.

Image

Similar issue with the "Text Search" and "Index Search" search bar for SICP JS

Image

@martin-henz martin-henz moved this to Todo high priority in SA 2425 CP3108 P09: Mobile edition Jan 29, 2024
@martin-henz martin-henz changed the title Long dialog titles cause the generic dialog components to extend beyond the screen dimensions on mobile view Mobile: Long dialog titles cause the generic dialog components to extend beyond the screen dimensions on mobile view Feb 5, 2024
@JovenSoh JovenSoh moved this from Todo high priority to In Progress in SA 2425 CP3108 P09: Mobile edition Feb 13, 2024
@Johnwz123 Johnwz123 mentioned this issue Feb 19, 2024
Merged
7 tasks
@Johnwz123 Johnwz123 moved this from In Progress to PR Issued in SA 2425 CP3108 P09: Mobile edition Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Johnwz123 Johnwz123

Labels
Enhancement New feature request
Projects
No open projects
SA 2425 CP3108 P09: Mobile edition
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix components extending beyond screen dimensions on mobile view Johnwz123/source-academy-frontend
3 participants
@ianyong @martin-henz @Johnwz123