Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix components extending beyond screen dimensions on mobile view #2792

Merged
merged 20 commits into from
Feb 26, 2024

Conversation

Johnwz123
Copy link
Contributor

Description

Closes #2241

The following components extend beyond the screen dimensions on mobile view:

  • ConfirmDialog and PromptDialog
  • SICP "Text Search" and "Index Search" search bar
  • Assessment OverviewCard

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

On a Mobile view:

ConfirmDialog and PromptDialog

  1. In Playground, switch to Source 2, 3 or 4 to access and "Enable Folder mode"
  2. Create a "New File" or "New Directory" with a long name.
  3. Try to "Delete" the file and the Dialog box will appear.

SICP "Text Search" and "Index Search" search bar

  1. In SICP JS, click "Text Search" or "Index Search" to display the search bar.

Assessment OverviewCard

  1. In the Assessments tabs (e.g. Missions, Quests), the Assessment OverviewCard layout should display with the icon on top of the description.

Checklist

  • I have tested this code
  • I have updated the documentation

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I have also added some minor style updates, and have fixed the formatting as well as tests for you.

@coveralls
Copy link

coveralls commented Feb 19, 2024

Pull Request Test Coverage Report for Build 8053090629

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 37.956%

Totals Coverage Status
Change from base Build 8053081504: 0.008%
Covered Lines: 5810
Relevant Lines: 14369

💛 - Coveralls

@sayomaki sayomaki requested review from RichDom2185 and removed request for martin-henz February 19, 2024 16:41
* Use classnames for conditional styling
* Replace unnecessary template literal with strings
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test snapshots, thanks!

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (and working), thanks for the changes!

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) February 26, 2024 17:36
@RichDom2185 RichDom2185 merged commit 3abd1c3 into source-academy:master Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants