Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display popular votes leaderboard #2785

Merged
merged 24 commits into from
Feb 24, 2024
Merged

Display popular votes leaderboard #2785

merged 24 commits into from
Feb 24, 2024

Conversation

jayjay19630
Copy link
Contributor

@jayjay19630 jayjay19630 commented Feb 15, 2024 •
edited
Loading

Description

This pull request adds a new tab which shows the popular votes leaderboard in the contest voting assessments. Relevant backend pull request to be be opened soon. This resolves issue #2699.

Changes To Be Made

  • Add a new popularVoteLeaderboard attribute to IContestVotingQuestion
  • Create new tab for popular vote leaderboard
  • Edit tests and snapshots

Checklist

  • I have tested this code

jayjay19630 and others added 12 commits February 14, 2024 00:59
@jayjay19630
Create new tab for popular votes leaderboard
d30e0ec
@jayjay19630
Merge branch 'source-academy:master' into DisplayPopularVotesLeaderboard
ca2abec
@jayjay19630
Rename popular votes to popular vote leaderboard
4230612
@jayjay19630
Edit assessment mocks and assessment types to include popular vote
d3a29d1
@jayjay19630
Modify tests
43e1e01
@jayjay19630
Merge branch 'DisplayPopularVotesLeaderboard' of github.com:jayjay196…
1c93b0e 
…30/source-academy-frontend into DisplayPopularVotesLeaderboard
@jayjay19630
Rename score property to calculated score and add popularity score
e6b5b08
@jayjay19630
Conditionally render different kinds of score depending on leaderboar…
1ac975f 
…dType
@jayjay19630
Revert "Conditionally render different kinds of score depending on le…
ae59bbb 
…aderboardType"

This reverts commit 1ac975f.
@jayjay19630
Revert "Rename score property to calculated score and add popularity …
53b9e74 
…score"

This reverts commit e6b5b08.
@jayjay19630
Edit snapshots
4908f07
@jayjay19630
Merge branch 'source-academy:master' into DisplayPopularVotesLeaderboard
3df696c
@coveralls
Copy link

coveralls commented Feb 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8023039313

Details

  • 0 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 36.999%
Totals Coverage Status
Change from base Build 8023025641: 0.03%
Covered Lines: 5743
Relevant Lines: 14626
💛 - Coveralls

@jayjay19630
Copy link
Contributor Author

jayjay19630 commented Feb 17, 2024 •
edited
Loading

Corresponding backend PR: source-academy/backend#1066

@jayjay19630 jayjay19630 mentioned this pull request Feb 17, 2024
Merged
4 tasks
RichDom2185
RichDom2185 reviewed Feb 18, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this, looking forward to the changes, just some of my thoughts below:

RichDom2185
RichDom2185 reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! But I'll delay the approval until the corresponding backend PR is also approved.

RichDom2185
RichDom2185 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichDom2185 RichDom2185 merged commit 0e106dd into source-academy:master Feb 24, 2024
6 checks passed
@jayjay19630 jayjay19630 deleted the DisplayPopularVotesLeaderboard branch February 26, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

@sayomaki sayomaki Awaiting requested review from sayomaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayjay19630 @coveralls @RichDom2185 @sayomaki