-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATA VIZ: Fix bugs, incorrect string and null displays #871
Conversation
Pull Request Test Coverage Report for Build 3374
💛 - Coveralls |
I'm getting
|
Can you add the relevant functions that were removed from this commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the recent bugs: all working.
Also canvas size is adapting to the size of the drawing.
Some more tests I performed... const ebst = make_empty_tree();
const bstll = make_tree(4, ebst, ebst);
const bstlr = make_tree(5, ebst, ebst);
const bstrl = make_tree(6, ebst, ebst);
const bstrr = make_tree(7, ebst, ebst);
const bstl = make_tree(2, bstll, bstlr);
const bstr = make_tree(3, bstrl, bstrr);
const bst = make_tree(1, bstl, bstr);
draw_data(bst); results in: Note the non-uniform padding of the image. const ist = list(1, "abc", x => x, pair(1,2), null, "superlongstring", 1234567890);
draw_data(ist); results in: Note the The data viz component doesn't resize together with the parent component (see below). It seems like the component has a fixed window height? If the window is overflowed, it would result in 2 scroll bars!!! |
Merging due to regression issues |
…y#871) * Fix bugs, incorrect string and null displays * Fix numbers not displaying correctly * Fix data visualizer breaking
null
slash in head of pair not displaying