Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better CMake compiler/MPI passing #39

Closed
zbeekman opened this issue Dec 4, 2015 · 4 comments
Closed

Better CMake compiler/MPI passing #39

zbeekman opened this issue Dec 4, 2015 · 4 comments
Assignees

Comments

@zbeekman
Copy link
Collaborator

zbeekman commented Dec 4, 2015

I'm wondering how common it is to pass the MPI wrappers to CMake directly. The folks @Homebrew seem to be under the impression that this is somewhat abnormal. I'm going to inquire on the CMake list and see what the consensus is there.

@zbeekman
Copy link
Collaborator Author

zbeekman commented Dec 4, 2015

Yes, it seems that the findMPI module might be the way to go. At least one person thinks that using the wrappers from CMake is a bad idea: https://cmake.org/pipermail/cmake/2011-June/045037.html

Also see Homebrew/legacy-homebrew#46547

@zbeekman
Copy link
Collaborator Author

zbeekman commented Dec 4, 2015

Here is some documentation for using the FindMPI CMake module: https://cmake.org/cmake/help/v3.4/module/FindMPI.html

@zbeekman
Copy link
Collaborator Author

Here is the documentation for FindMPI: https://cmake.org/cmake/help/v3.4/module/FindMPI.html

This should probably be used along with CMake's configure_file capabilities to substitute in the right EXE name, flags etc. in the CAF wrapper scripts.

@zbeekman zbeekman added this to the 1.2.3 release milestone Jan 7, 2016
@zbeekman zbeekman modified the milestones: 2.x release, 1.2.3 release Feb 24, 2016
@rouson rouson removed this from the 2.0.0 release milestone May 24, 2016
@zbeekman
Copy link
Collaborator Author

OK, 193546d seems to solve this quite elegantly, if I do say so myself. I would like to rework the caf and caf_run scripts to use configure_file and full paths to the compiler and MPI implementation, and also run it through shellcheck. I'll open a new issue for this, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants