Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SYNC TEAM team-value to be a child team #656

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

nathanweeks
Copy link
Contributor

Summary of changes

Fix #655 by allowing the SYNC TEAM team-value argument to be a child team.

Added a unit test.

Rationale for changes

Fortran 2018 standard compliance (and I need it for an application).

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the [contributing guidelines]
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open [Pull Requests] for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The [commit messages] follow [best practices]
    • Test coverage is maintained or increased after this is merged

@ghost ghost added the needs-review label Apr 26, 2019
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #656 into master will increase coverage by 0.46%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage    54.1%   54.56%   +0.46%     
==========================================
  Files           3        3              
  Lines        2924     2925       +1     
==========================================
+ Hits         1582     1596      +14     
+ Misses       1342     1329      -13

@zbeekman zbeekman merged commit aadeb40 into sourceryinstitute:master Apr 26, 2019
@ghost ghost removed the needs-review label Apr 26, 2019
@zbeekman
Copy link
Collaborator

Thanks so much @nathanweeks!

@nathanweeks nathanweeks deleted the issue-655-sync-team branch April 26, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SYNC TEAM doesn't support child team-value
2 participants