Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install.sh): download GCC release tar balls #730

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

rouson
Copy link
Member

@rouson rouson commented Mar 17, 2021

coverage on master
Codecov branch

Summary of changes

install.sh now downloads GCC tar balls instead of cloning GCC release branches.

Rationale for changes

Downloading release tar balls is much faster than cloning branches.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

instead of cloning release branches, which is a much slower
process
Copy link
Collaborator

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I watched you test that the url are correct both ways.

@everythingfunctional everythingfunctional merged commit ef8069d into main Mar 17, 2021
@everythingfunctional everythingfunctional deleted the download-gcc-release-tar-balls branch March 17, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants