Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests fail under Travis-CI / Ubuntu 12.04 #20

Closed
lunixbochs opened this issue Nov 17, 2014 · 4 comments
Closed

Some tests fail under Travis-CI / Ubuntu 12.04 #20

lunixbochs opened this issue Nov 17, 2014 · 4 comments

Comments

@lunixbochs
Copy link
Contributor

I'm trying to add Travis support, but some of the tests fail:

=== RUN TestGCM
--- FAIL: TestGCM (0.00 seconds)
    ciphers_test.go:154: Decryption with b=256: Failed to add authenticated data: failed to add additional authenticated data
=== RUN TestGCMWithNoAAD
--- FAIL: TestGCMWithNoAAD (0.00 seconds)
    ciphers_test.go:172: Decryption failure: Failed to perform a decryption: failed to decrypt
=== RUN TestBadTag
--- FAIL: TestBadTag (0.00 seconds)
    ciphers_test.go:198: Decryption failure: Failed to perform a decryption: failed to decrypt
=== RUN TestBadCiphertext
--- FAIL: TestBadCiphertext (0.00 seconds)
    ciphers_test.go:224: Decryption failure: Failed to add authenticated data: failed to add additional authenticated data
=== RUN TestBadAAD
--- FAIL: TestBadAAD (0.00 seconds)
    ciphers_test.go:250: Decryption failure: Failed to add authenticated data: failed to add additional authenticated data

The travis-ci.org boxes are running Ubuntu 12.04. I installed libssl-dev as a dependency.

Tests do not fail on my own Ubuntu 14.04 VM. I'm setting up a 12.04 VM to debug.

@thepaul
Copy link
Contributor

thepaul commented Nov 17, 2014

The authenticated encryption functions were added in OpenSSL 1.1.0 and backported to OpenSSL 1.0.1. Ubuntu decided not to add support for them in 12.04, for (probably) reasons (but I don't know them).

We should probably have the tests somehow detect the situation where the functions are not available and do a t.Skip() or something, since testing them in places that don't have the underlying functionality doesn't make sense.

@lunixbochs
Copy link
Contributor Author

I kinda disagree with that solution, because then you have active code not covered by tests. I think a better solution (until travis-ci.org gets Ubuntu 14.04 support) would be to come up with a travis build that installs a newer version of OpenSSL to test against.

@thepaul
Copy link
Contributor

thepaul commented Nov 18, 2014

That sounds fine to me. Here we just run the tests on Debian Wheezy, which does have the GCM functions.

@zeebo
Copy link
Member

zeebo commented Mar 3, 2017

Closing due to inactivity.

@zeebo zeebo closed this as completed Mar 3, 2017
merlin-northern pushed a commit to merlin-northern/openssl that referenced this issue Aug 20, 2020
Fix: Mirror the OpenSSL library name with the wrapper
nathan454 pushed a commit to nathan454/openssl that referenced this issue Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants