-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tests fail under Travis-CI / Ubuntu 12.04 #20
Comments
The authenticated encryption functions were added in OpenSSL 1.1.0 and backported to OpenSSL 1.0.1. Ubuntu decided not to add support for them in 12.04, for (probably) reasons (but I don't know them). We should probably have the tests somehow detect the situation where the functions are not available and do a t.Skip() or something, since testing them in places that don't have the underlying functionality doesn't make sense. |
I kinda disagree with that solution, because then you have active code not covered by tests. I think a better solution (until travis-ci.org gets Ubuntu 14.04 support) would be to come up with a travis build that installs a newer version of OpenSSL to test against. |
That sounds fine to me. Here we just run the tests on Debian Wheezy, which does have the GCM functions. |
Closing due to inactivity. |
Fix: Mirror the OpenSSL library name with the wrapper
ci: add go-test-setup action
I'm trying to add Travis support, but some of the tests fail:
The travis-ci.org boxes are running Ubuntu 12.04. I installed libssl-dev as a dependency.
Tests do not fail on my own Ubuntu 14.04 VM. I'm setting up a 12.04 VM to debug.
The text was updated successfully, but these errors were encountered: