feat: Add rewards and sUSDC #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikozalo
approved these changes
Mar 7, 2025
src/Ethereum.sol
Outdated
| @@ -41,7 +42,9 @@ library Ethereum { | |||
| /*** SparkDAO Addresses ***/ | |||
| /******************************************************************************************************************/ | |||
|
|
|||
| address internal constant SPARK_PROXY = 0x3300f198988e4C9C63F75dF86De36421f06af8c4; | |||
| address internal constant SPARK_PROXY = 0x3300f198988e4C9C63F75dF86De36421f06af8c4; | |||
| address internal constant SPARK_REWARDS_ADMIN = 0xF649956f43825d4d7295a50EDdBe1EDC814A3a83; // TODO: Best way to differentiate between this and MULTISIG_REWARDS? | |||
There was a problem hiding this comment.
We might want a SPARK_REWARDS_MULTISIG as well to make it clear that the admin and the wallet are not necessarily the same. It is in the current setup though.
There was a problem hiding this comment.
Yes SPARK_REWARDS_MULTISIG is good. Also, add it to the other networks.
MULTISIG_REWARDS can be changed to SPARKLEND_REWARDS_MULTISIG
hexonaut
approved these changes
Mar 7, 2025
lucas-manuel
added a commit
that referenced
this pull request
Mar 21, 2025
* feat: add deployments and testing * fix: formatting * feat: get deployy tests working, refactor structure * feat: get deployy tests working, refactor structure * feat: finish deploy scripts refactor * feat: add init * feat: add init * feat: mainnet deploy and init working * feat: tests passing * fix: cleanup * feat: update to use interfaces * fix: alignment and struct * feat: update to add separate init scripts * feat: check constructor params * feat: add unlimited rate data sanity checks * feat: get constructor tests working * feat: update to add rate limit tests * feat: add init failure tests for mainnet controller * feat: update to add remaining failure mode tests * starting on sepolia support * more work on sepolia testnet * move usds join back to common * more work on sepolia support * forge install: erc20-helpers * more progress on sepolia deploy * mint usds working * got psm swap working * started on base * starting on base * almost finished base support * forge install: dss-test * full sepolia working * add safe * forge install: safe-smart-account v1.4.1 * fix imports * create deploy * update to latest alm controller and add vat ilk line * add more addresses * remove safe deploy logic; new sepolia release * use 1 for rate * cleanup: Sepolia refactor (SC-745) (#40) * formatting: regroup and reorder imports * formatting: set up declarations, change function naming * formatting: general formatting throughout * formatting: add step by step comments, move function * fix: update remappings, update instance name * fix: move variable assignments * feat: update to mint funds to alm proxy and use psm deploy lib * fix: rm comment * fix: sanity check and psm lib --------- Co-authored-by: lucas-manuel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.