SQLite3::TestDatabaseURI test failures with system sqlite

[voxik]

I am observing following errors on Fedora Rawhide using Fedora sqlite-3.47.2-2.fc42.x86_64:

$ ruby -I~/build/BUILD/rubygem-sqlite3-2.5.0-build/sqlite3-2.5.0/usr/lib64/gems/ruby/sqlite3-2.5.0:lib:test -e 'Dir.glob "./test/test_*.rb", &method(:require)'
---
:ruby: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [x86_64-linux]
:gem:
  :version: 2.5.0
:sqlite:
  :compiled: 3.47.2
  :loaded: 3.47.2
  :packaged: false
  :precompiled: false
  :sqlcipher: false
  :threadsafe: true

... snip ...

  1) Failure:
SQLite3::TestDatabaseURI#test_open_relative_file_uri [test/test_database_uri.rb:26]:
Expected path 'test.db' to exist.

  2) Error:
SQLite3::TestDatabaseURI#test_open_file_uri_readonly:
SQLite3::CantOpenException: unable to open database file
    lib/sqlite3/database.rb:166:in 'SQLite3::Database#open_v2'
    lib/sqlite3/database.rb:166:in 'SQLite3::Database#initialize'
    test/test_database_uri.rb:37:in 'Class#new'
    test/test_database_uri.rb:37:in 'block in SQLite3::TestDatabaseURI#test_open_file_uri_readonly'
    /usr/share/ruby/tempfile.rb:444:in 'Tempfile.open'
    test/test_database_uri.rb:36:in 'SQLite3::TestDatabaseURI#test_open_file_uri_readonly'

  3) Error:
SQLite3::TestDatabaseURI#test_open_absolute_file_uri:
SQLite3::CantOpenException: unable to open database file
    lib/sqlite3/database.rb:166:in 'SQLite3::Database#open_v2'
    lib/sqlite3/database.rb:166:in 'SQLite3::Database#initialize'
    test/test_database_uri.rb:12:in 'Class#new'
    test/test_database_uri.rb:12:in 'block in SQLite3::TestDatabaseURI#test_open_absolute_file_uri'
    /usr/share/ruby/tempfile.rb:444:in 'Tempfile.open'
    test/test_database_uri.rb:11:in 'SQLite3::TestDatabaseURI#test_open_absolute_file_uri'

Seeing:

sqlite3-ruby/ext/sqlite3/extconf.rb

Line 65 in 555738d

"-DSQLITE_USE_URI=1",

while I can't spot similar option in Fedora package, I assume Fedora SQLite package does not support this feature and therefore the test fails.

If the assumption is right, the question is what apart of the test case is broken and also if I should ask Fedora packager to enable the -DSQLITE_USE_URI=1.

[flavorjones]

Hi, thanks for asking about this, and sorry you're having trouble.

Your diagnosis is correct. In #571 I added support for URI filenames, but this depends on a compile-time setting that you correctly identified as SQLITE_USE_URI that is probably not being set by the fedora packager.

Sadly, there's no good way I know of to check config settings at runtime. That said, what I can do is skip those tests if you're not using the vendored sqlite (I should probably have done that in the original PR but none of the CI jobs that test against system libraries were failing (because I test mostly against debian and the debian package has this feature enabled)).

[flavorjones]

See #613

[voxik]

Thank you for super fast response.

But could you elaborate about plans for this feature? I think I can ask Fedora maintainers to enable the URI support. But there likely might be also some downsides, if upstream does not enable that feature by default.

[flavorjones]

@voxik I'm not sure what you mean by "plans for this feature." The feature is described here: https://www.sqlite.org/uri.html

Basically, if it's enabled, then users can pass a URI string to SQLite3::Database.new, otherwise they can't. By extension, then Rails database configurations can contain URIs which allows applications to pass in some options/configurations to SQLite via that configuration.

But the compile-time option is just setting the default to off. It's possible to turn it back on at runtime. I wouldn't worry about it, personally.