Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new config option with readme documentation #48

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MattMakes
Copy link

Adding this to allow us to configure an http/https agent for keep alive configurations. We've seen a large number of sockets being opened up by this library when used by our projects and believe it's due to not having configs available to update the request node module (which is now deprecated, btw, but that'll have to be another PR..).

The example provides an usage example - but the simplicity of it would allow for using something more complex like this too: https://github.com/node-modules/agentkeepalive

Please let me know if you have questions or concerns.

@bparmar-splunk bparmar-splunk changed the base branch from master to develop October 7, 2022 04:18
@bparmar-splunk
Copy link

HI @MattMakes,
This PR contains code conflicts with current branch codebase.
Could you please resolve the conflicts and push it again?

Also, it would add more clarity to this change, if you add test case supporting this use-case.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants