Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Log4J dependency due to Scio 0.13.3 bug #671

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

monzalo14
Copy link
Member

@monzalo14 monzalo14 commented Sep 21, 2023

Fixes #672

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #671 (90bb65a) into master (70c6157) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          40       40           
  Lines        1710     1710           
  Branches      140      140           
=======================================
  Hits         1221     1221           
  Misses        489      489           
Flag Coverage Δ
ratatoolCli 3.07% <ø> (ø)
ratatoolCommon ∅ <ø> (?)
ratatoolDiffy 30.80% <ø> (ø)
ratatoolExamples 15.94% <ø> (ø)
ratatoolSampling 62.58% <ø> (ø)
ratatoolScalacheck 81.67% <ø> (ø)
ratatoolShapeless 4.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@monzalo14 monzalo14 merged commit c4cefd2 into spotify:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Log4J dependency
2 participants