add build script for linux #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much ! I do not use debian based distributions, so let me document myself and merge once I understand the code fully. |
spoutn1k
reviewed
Nov 6, 2022
andresbott
commented
Nov 6, 2022
linux-build/makefile
Outdated
| build-builder: ## build the builder image that contains the source code | ||
| @docker build -f build-linux.dockerfile -t mcmap-builder:latest ./.. | ||
|
|
||
| build-linux: build-builder ## build for linux using docker |
There was a problem hiding this comment.
This steps could also be out into a build script instead of having them in the make file.
furthermore build-linux and package-linux could probably unified into a single target.
similar to what i did here: https://github.com/andresbott/minecraft-overviewer-package/blob/main/targets/bullseye-64/build.sh
andresbott
commented
Nov 7, 2022
| contents: | ||
| - src: ./mcmap # this path is mounted into the container | ||
| dst: /usr/local/bin/mcmap | ||
| file_info: |
There was a problem hiding this comment.
nice!
i didn't know this :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this small build logic to build and package the tool in debian compatible package.
Feel free to take the code and refactor it as wish.