Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #72 #73

Merged
merged 2 commits into from
Feb 2, 2023
Merged

fixes #72 #73

merged 2 commits into from
Feb 2, 2023

Conversation

Eric-Maddox
Copy link
Contributor

fix IOException after MS changed response
use correct ContentType to avoid 400 error
Includes unit test.

use correct ContentType to avoid 400 error
@spyder007
Copy link
Owner

@Eric-Maddox I will gladly create a release for this, but the pipeline is not currently building, can you take a look?

@Eric-Maddox
Copy link
Contributor Author

I don't know why the build is failing. If I create an empty folder, and do a git clone from my fork, then type mvn it builds successfully.
The method it's complaining about is InputStream.nullInputStream(). Documentation says it's been their "Since 11"
https://download.java.net/java/early_access/panama/docs/api/java.base/java/io/InputStream.html#nullInputStream()

@olamartensson
Copy link

Hi! We are using this plugin and are now seeing the exact same issue on our TeamCity instance.

Could the broken build be fixed by bumping the Java version in the GitHub workflow config? It seems to currently be configured for Java 8 (java-version: 1.8) and the nullInputStream() method was added in Java 11, as you wrote.

@spyder007
Copy link
Owner

@Eric-Maddox Can you please sync with the latest commit on master? I moved the build to JDK 11, which hopefully fixes this build error.

Copy link
Owner

@spyder007 spyder007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spyder007 spyder007 merged commit 803d27b into spyder007:master Feb 2, 2023
@spyder007
Copy link
Owner

@Eric-Maddox / @olamartensson -> This is merged and I created a new release (2.13.0).

@olamartensson
Copy link

Thanks a lot! I have now tested the new release on our TeamCity instance and Teams notifications are working again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants