add modeluri for model zoo to save #1281
Merged
+68
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shendiaomo
reviewed
Nov 29, 2019
| @@ -23,7 +23,8 @@ import ( | |||
| pb "sqlflow.org/sqlflow/pkg/proto" | |||
| ) | |||
|
|
|||
| const bufSize = 4 * 1024 | |||
| // TEXT/STRING field support 64KB maximumn storage size | |||
| const bufSize = 32 * 1024 | |||
There was a problem hiding this comment.
Can we make this bufSize configurable? If my memory serves me right, the string type in MaxCompute has a much bigger size than 64KB.
There was a problem hiding this comment.
Better to keep it constant for better saved model migrations.
| return fmt.Errorf("error modelURI format: %s", modelURI) | ||
| } | ||
| } | ||
| db, err := NewDB(session.DbConnStr) |
There was a problem hiding this comment.
Is it possible to unify sqlfs with modelURI? For example, can we make sqlfs://database_name/table_name behave the same as table_name? This seems to improve consistency.
There was a problem hiding this comment.
oss:// and file:// are well know URI prefixes. We do not intend to invent a new one.
shendiaomo
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1063