Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflection of unique constraints #199

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix reflection of unique constraints #199

merged 1 commit into from
Apr 29, 2020

Conversation

eeshugerman
Copy link
Contributor

@eeshugerman eeshugerman commented Apr 23, 2020

I noticed this because alembic revision --autogenerate was inserting a bunch of op.create_unique_constraint calls in revision scripts, even when the constraints in question already exist in the database.

Todos

  • MIT compatible
  • Tests | N/A?
  • Documentation | N/A?
  • Updated CHANGES.rst

Sorry, something went wrong.

I noticed this because `alembic revision --autogenerate` was inserting a bunch of `op.create_unique_constraint` calls in revision scripts, even when the constraints in question already exist in the database.
Copy link
Member

@jklukas jklukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are passing, so LGTM.

@jklukas jklukas merged commit e183ddd into sqlalchemy-redshift:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants