-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to electron stable major, v1.1.2 #169
Conversation
Update: It seems there's Node v6 incompatibility with pg module we use. There's a problem with authentication, in short error saying that password is wrong keeps showing up, while password is actually alright. There's an open issue. Since electron ~1.1 uses Node v6, I guess we hit another wall on updating to a major release. |
Wow. Maybe one day we gonna be able to update to electorn 1.x 😆 |
Haha, somewhere in 2030 maybe. Well, I'll leave this open, because that issue might be solved soon so you can pull that changes to your fork we are pulling |
@maxcnunes There is actually already existing commit that solves this issue, so you call pull it on your fork. Check it out. |
I have upgraded my pg branch. Since pg is a dependency based in a branch I guess there is no need releasing a new version of sqlectron-core. Just installing sqlectron-core should a get new version of pg module. |
It's working 🎉 🙌 |
Seems is not working properly. At least I cant connect over SSH. Could you check if it is working for you? Maybe we need revert again to |
Ah, seems I've overlooked that :/ Could you please try debug it, and if it is not something that can be easily solved, we should revert this commit to |
The few minutes I tried investigating it I could not find the solution or even the exactly problem. Since I hope releasing a new version this week I guess is better revert it now. And later we try again upgrading it. |
Sounds good. Feel free to revert it 👍 |
I guess this is the problem electron/electron#5736. I am reverting to the previous used version. But lets try to upgrade again once that PR is merged. |
Finally, major version that works for us! 🎉
Promises are now handled properly. There are bunch of warnings thrown in console but I guess they are related to Chrome v50.0.x, since I noticed them as of electron v1.1.0 which was bump to newer Chrome version. App works as expected anyways! :)
Since minor changes related to migrating to new API were already implemented in 131bf85, this upgrade did not need any additional changes.