-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Expo config plugin #193
base: master
Are you sure you want to change the base?
Conversation
@fobos531 EXPO is a framework built on top of react native and it’s officially supported by react native. It’s great if this change works. Can you please verify if that PR works with EXPO and not breaking the current quick start app? if so, you can approve and merge PR, then we can enable our plugin with EXPO. |
Any update on this PR? |
Any movement on this at all? |
Pretty sure that it isn't able to associate with any podspec at present and will fail in a build as the build phase this particular line is returning anything in the prebuild phase.
This returns undefined implying that there is no podspec associated with the config plugin itself for iOS which is a requirement. |
We're also looking to integrate Square into our existing Production Expo app (SDK 50). We were about to start implementing stories to add support after seeing the React Native blog post but a customary search found this PR as well as #208, so it looks like it's not possible. Looks like Stripe is the only processor I can find that documents support for Expo, but I'd love to be proven wrong since we already use Square in other parts of our organisation, so we were hoping to use it in our Expo app too. |
Please check this thread: #236 (comment) it will give you some insight for future problem due to adding build script in iOS which I have solved. |
Any updates on this? |
Summary
This PR adds support for automatically configuring the native Android/iOS (required for enabling Google/Apple Pay) projects using Expo's config plugins for users that use Expo.
Changelog
Test Plan
N/A