Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Expo config plugin #193

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat: add Expo config plugin #193

wants to merge 12 commits into from

Conversation

fobos531
Copy link

Summary

This PR adds support for automatically configuring the native Android/iOS (required for enabling Google/Apple Pay) projects using Expo's config plugins for users that use Expo.

Changelog

  • added Expo config plugin
  • bumped react native dependency

Test Plan

N/A

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2023

CLA assistant check
All committers have signed the CLA.

@charmiswebiots
Copy link

@fobos531 EXPO is a framework built on top of react native and it’s officially supported by react native. It’s great if this change works. Can you please verify if that PR works with EXPO and not breaking the current quick start app? if so, you can approve and merge PR, then we can enable our plugin with EXPO.

@kuldip-simform
Copy link

Any update on this PR?

@JoshKeenan
Copy link

Any movement on this at all?

@JoshKeenan
Copy link

Pretty sure that it isn't able to associate with any podspec at present and will fail in a build as the build phase this particular line is returning anything in the prebuild phase.

const podspecs = glob.sync('{ios/**/,}*.podspec');

This returns undefined implying that there is no podspec associated with the config plugin itself for iOS which is a requirement.

@danrivett danrivett mentioned this pull request Mar 12, 2024
@danrivett
Copy link

We're also looking to integrate Square into our existing Production Expo app (SDK 50).

We were about to start implementing stories to add support after seeing the React Native blog post but a customary search found this PR as well as #208, so it looks like it's not possible.

Looks like Stripe is the only processor I can find that documents support for Expo, but I'd love to be proven wrong since we already use Square in other parts of our organisation, so we were hoping to use it in our Expo app too.

@kuldip-simform
Copy link

Please check this thread: #236 (comment)

it will give you some insight for future problem due to adding build script in iOS which I have solved.

@timmyjose
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants