Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "manage workspaces" page #128

Merged
merged 8 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
} from "./components/ui/breadcrumb";
import { useBreadcrumb } from "./hooks/useBreadcrumb";
import { RouteWorkspace } from "./routes/route-workspace";
import { Workspaces } from "./components/Workspaces";

function App() {
const { data: prompts, isLoading } = usePromptsData();
Expand Down Expand Up @@ -59,6 +60,7 @@ function App() {
<Route path="/help/:section" element={<Help />} />
<Route path="/certificates" element={<Certificates />} />
<Route path="/workspace/:id" element={<RouteWorkspace />} />
<Route path="/workspaces" element={<Workspaces />} />
<Route
path="/certificates/security"
element={<CertificateSecurity />}
Expand Down
44 changes: 44 additions & 0 deletions src/components/Workspaces.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { render } from "@/lib/test-utils";
import { screen, waitFor, within } from "@testing-library/react";
import { describe, expect, it } from "vitest";
import { Workspaces } from "./Workspaces";

describe("Workspaces page", () => {
beforeEach(() => {
render(<Workspaces />);
});

it("has a title", () => {
expect(
screen.getByRole("heading", { name: /manage workspaces/i }),
).toBeVisible();
});

it("has a table with the correct columns", () => {
expect(screen.getByRole("columnheader", { name: /name/i })).toBeVisible();
expect(
screen.getByRole("columnheader", { name: /configuration/i }),
).toBeVisible();
});

it("has a row for each workspace", async () => {
await waitFor(() => {
expect(screen.getAllByRole("row").length).toBeGreaterThan(1);
});

expect(
screen.getByRole("rowheader", { name: /myworkspace/i }),
).toBeVisible();
expect(
screen.getByRole("rowheader", { name: /anotherworkspae/i }),
).toBeVisible();

const firstRow = screen.getByRole("row", { name: /myworkspace/i });
const firstButton = within(firstRow).getByRole("link", {
name: /settings/i,
});

expect(firstButton).toBeVisible();
expect(firstButton).toHaveAttribute("href", "/workspace/myworkspace");
});
});
54 changes: 54 additions & 0 deletions src/components/Workspaces.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import { useWorkspacesData } from "@/hooks/useWorkspacesData";
import {
Cell,
Column,
Heading,
LinkButton,
Row,
Table,
TableBody,
TableHeader,
} from "@stacklok/ui-kit";
import { Settings } from "lucide-react";

export function Workspaces() {
const result = useWorkspacesData();
const workspaces = result.data?.workspaces ?? [];

return (
<div>
<Heading level={1} className="mb-5">
Manage Workspaces
</Heading>

<Table aria-label="List of workspaces">
<Row>
<TableHeader>
<Column id="name" isRowHeader className="w-full">
Name
</Column>
<Column id="configuration" className="w-56">
Configuration
</Column>
</TableHeader>
</Row>
<TableBody>
{workspaces.map((workspace) => (
<Row key={workspace.name}>
<Cell>{workspace.name}</Cell>
<Cell>
<LinkButton
href={`/workspace/${workspace.name}`}
variant="tertiary"
>
<Settings />
Settings
</LinkButton>
</Cell>
</Row>
))}
</TableBody>
</Table>
</div>
);
}
30 changes: 20 additions & 10 deletions src/mocks/msw/fixtures/GET_WORKSPACES.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
[
{
"name": "workspace-1",
"is_active": true
},
{
"name": "workspace-2",
"is_active": false
}
]
{
"workspaces": [
{
"name": "default",
"is_active": true
},
{
"name": "myworkspace",
"is_active": false
},
{
"name": "anotherworkspae",
"is_active": false
},
{
"name": "favoriteworkspace",
"is_active": false
}
]
}
Loading