fix: parsing promptList text and breadcrumb #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12926923723Details
💛 - Coveralls |
alex-mcgovern
previously approved these changes
Jan 22, 2025
kantord
previously approved these changes
Jan 23, 2025
| // there some edge cases in copilot where the prompts are not correctly parsed. In this case is better to show the filepath | ||
| if (compareCode || filePath) { | ||
| if (filePath) | ||
| return `Prompt on file${filePath[0]?.trim().toLocaleLowerCase()}`; |
There was a problem hiding this comment.
Suggested change
| return `Prompt on file${filePath[0]?.trim().toLocaleLowerCase()}`; | |
| return `Prompt on file: ${filePath[0]?.trim().toLocaleLowerCase()}`; |
There was a problem hiding this comment.
The reason why I didn't add the colon is because it is already included in the filepath from AI, so it would be redundant. The same for code snippet
| return `Prompt on file${filePath[0]?.trim().toLocaleLowerCase()}`; | ||
|
|
||
| if (compareCode) | ||
| return `Prompt from snippet ${compareCode[0]?.trim().toLocaleLowerCase()}`; |
There was a problem hiding this comment.
Suggested change
| return `Prompt from snippet ${compareCode[0]?.trim().toLocaleLowerCase()}`; | |
| return `Prompt from snippet: ${compareCode[0]?.trim().toLocaleLowerCase()}`; |
| "render code with file path", | ||
| { | ||
| message: "<file> ```tsx // filepath: /tests/my-test.tsx import", | ||
| expected: /Prompt on file\/\/ filepath: \/tests\/my-test.tsx/i, |
There was a problem hiding this comment.
Suggested change
| expected: /Prompt on file\/\/ filepath: \/tests\/my-test.tsx/i, | |
| expected: /Prompt on file: \/\/ filepath: \/tests\/my-test.tsx/i, |
alex-mcgovern
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some issues with copilot, I tried to checked some specific use cases: