Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react-hook-form field array for provider muxes #345

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Feb 21, 2025

Integrates the useFieldArray hook from react-hook-form to add zod-schema driven validation to the Muxing config.

Closes #367 — which originated from a user issue on Github

Copy link

stacklok-cloud-staging bot commented Feb 21, 2025

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 48e7ed2a:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

@alex-mcgovern alex-mcgovern force-pushed the feat/react-hook-form-provider-muxes branch from e1bdbe8 to f12e626 Compare March 6, 2025 08:36
Copy link
Collaborator Author

@alex-mcgovern alex-mcgovern Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporary state, will be resolved before merge, same for other form-* components in this tmp directory

@coveralls
Copy link
Collaborator

coveralls commented Mar 17, 2025

Pull Request Test Coverage Report for Build 13903674755

Details

  • 63 of 93 (67.74%) changed or added relevant lines in 21 files are covered.
  • 50 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-4.6%) to 61.874%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/workspace/components/form-mux-button-delete-rule.tsx 1 2 50.0%
src/features/workspace/components/form-mux-context-provider.tsx 6 7 85.71%
src/features/workspace/components/tmp/form-discard-changes-button.tsx 2 3 66.67%
src/features/workspace/components/tmp/form-submit-button.tsx 0 1 0.0%
src/features/workspace/lib/handle-mux-form-errors.ts 5 6 83.33%
src/features/workspace/components/form-mux-rules.tsx 12 14 85.71%
src/features/workspace/components/tmp/form-radio-group.tsx 0 5 0.0%
src/features/workspace/components/tmp/form-reset-on-submit.tsx 0 5 0.0%
src/features/workspace/components/tmp/form-checkbox-group.tsx 0 6 0.0%
src/features/workspace/components/form-mux-fields-array.tsx 2 9 22.22%
Files with Coverage Reduction New Missed Lines %
src/components/SortableArea.tsx 3 0.0%
src/features/workspace/lib/utils.ts 8 0.0%
src/features/workspace/hooks/use-muxing-rules-form-workspace.ts 19 0.0%
src/features/workspace/components/workspace-models-dropdown.tsx 20 0.0%
Totals Coverage Status
Change from base Build 13900755380: -4.6%
Covered Lines: 904
Relevant Lines: 1379

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore]: Add validation & error state to muxing config page.
2 participants