Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable provider model updating when updating provider itself #1014

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Feb 11, 2025

This now calls the model updating logic when updating the provider
itself. Thus allowing us to have a way to update the model list.

Signed-off-by: Juan Antonio Osorio [email protected]

This now calls the model updating logic when updating the provider
itself. Thus allowing us to have a way to update the model list.

Signed-off-by: Juan Antonio Osorio <[email protected]>
Copy link
Contributor

@aponcedeleonch aponcedeleonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to update the models of a provider at server startup, i.e. in function initialize_provider_endpoints. Right now, if the provider already exists it will not try to get its models.

@JAORMX
Copy link
Contributor Author

JAORMX commented Feb 12, 2025

We still need to update the models of a provider at server startup, i.e. in function initialize_provider_endpoints. Right now, if the provider already exists it will not try to get its models.

Mind if I do that in a separate PR?

Copy link
Contributor

@aponcedeleonch aponcedeleonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The remaining functionality will be done in a separate PR

@JAORMX JAORMX merged commit f361178 into main Feb 12, 2025
9 checks passed
@JAORMX JAORMX deleted the update-models-providers branch February 12, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants