feat: remove not needed encryption of secrets #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrobla
requested review from
lukehinds,
aponcedeleonch and
jhrozek
and removed request for
lukehinds and
aponcedeleonch
jhrozek
reviewed
Feb 21, 2025
jhrozek
reviewed
Feb 21, 2025
yrobla
force-pushed
the
issue-929
branch
6 times, most recently
from
da2f6a8 to
0861a59
Compare
jhrozek
reviewed
Mar 3, 2025
Instead use an uuid generator as we do for pii, and reuse same session store mechanism Closes: #929
jhrozek
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use an uuid generator as we do for pii, and reuse same session store mechanism
Closes: #929