Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire in Persona matching to muxing #1244

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aponcedeleonch
Copy link
Contributor

Closes: #1220

This PR:

  • Changes the way the queries are checked to determine if they match a persona description. Before we were using SQLite now we use Numpy
  • Adds a new MuxMatcherType called persona_description that checks if the user messages in a request match a persona description

@aponcedeleonch aponcedeleonch requested a review from JAORMX March 6, 2025 16:11
Closes: #1220

This PR:
- Changes the way the queries are checked to determine if they
match a persona description. Before we were using SQLite now we use Numpy
- Adds a new MuxMatcherType called `persona_description` that checks
if the user messages in a request match a persona description
@aponcedeleonch aponcedeleonch force-pushed the wire-persona-to-mux-rules branch from 531745e to 2b4b13c Compare March 6, 2025 16:12
@aponcedeleonch aponcedeleonch marked this pull request as draft March 6, 2025 16:14
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far this makes sense to me. Time to test it!

@aponcedeleonch aponcedeleonch force-pushed the wire-persona-to-mux-rules branch from ffd932c to 4eb38f6 Compare March 7, 2025 10:15
Copy link
Contributor

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on this , had discussion earlier and there is a change of approach underway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Wire in Personas as muxing rules
3 participants