Use github.ref_name for codegate version
#707
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto-generated tag was used to set the codegate version. This had relevant information, but is not the version we actually wanted to set. This instead uses github action context variables to set the version appropriately. For Releases (the trigger for the image publish job) the `ref_name` refers to the tag the release had attached. This is what's used. Signed-off-by: Juan Antonio Osorio <[email protected]>
rdimitrov
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-generated tag was used to set the codegate version. This had
relevant information, but is not the version we actually wanted to set.
This instead uses github action context variables to set the version
appropriately.
For Releases (the trigger for the image publish job) the
ref_namerefers to the tag the release had attached. This is what's used.
Signed-off-by: Juan Antonio Osorio [email protected]