added lemmas to tsv even without verbose output format option #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngledLuffa
reviewed
Mar 17, 2025
| sb.append(word); | ||
| sb.append('\t'); | ||
| if (outputLemmas) { | ||
| String lemma = ((HasLemma) hw).lemma(); |
There was a problem hiding this comment.
would you check that it is a HasLemma here first?
There was a problem hiding this comment.
I just followed original use of HasTag without check pattern.
HasWord, HasTag & HasLemma are implemented through src/edu/stanford/nlp/ling/AbstractToken.java
There was a problem hiding this comment.
Yes, that makes sense. However, the assumption is that every class that comes through the tagger will be both HasWord and HasTag, whereas if the tagger is using the WordTag class, there may not be a Lemma.
|
I am drafting a new release this weekend, and aside from the change I requested I also need it merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.