-
Notifications
You must be signed in to change notification settings - Fork 258
Support more services #4487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more services #4487
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for additional services by implementing a new chain state service, extending the state API with asynchronous methods, and updating dependency management in Cargo.toml files.
- Added a new ChainStateService implementation in the state/service module
- Extended the state API with asynchronous service methods in state/api with corresponding message types
- Updated workspace configuration and dependencies across multiple Cargo.toml files
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
state/service/src/service.rs | Implements the ChainStateService with methods for state queries |
state/service/src/lib.rs | Exposes the ChainStateService |
state/service/Cargo.toml | Adds dependencies for state service |
state/api/src/mock/* | Adds mock implementations for the chain state API |
state/api/src/message.rs | Defines new message types for state service requests/responses |
state/api/src/lib.rs | Implements ChainStateAsyncService and integrates new response handling |
account/src/account_storage.rs | Minor update to use a different import order for RocksdbConfig |
account/Cargo.toml | Adjusts dependency comments |
Cargo.toml | Updates workspace members and dependency configurations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new ChainStateService along with supporting API changes to enhance service support in the Starcoin ecosystem. Key changes include:
- New implementation of ChainStateService and its integration via async and actor service interfaces in state/service.
- Addition of state API endpoints and mock services in state/api to handle various state queries and proofs.
- Updates to workspace configuration files (Cargo.toml) and minor adjustments in account module imports to align with the new changes.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
state/service/src/service.rs | Introduces ChainStateService and its API implementation. |
state/service/src/lib.rs | Exports the new ChainStateService. |
state/service/Cargo.toml | Adds required dependencies for the new service functionality. |
state/api/src/mock/mod.rs & mock_chain_state_service.rs | Provides mock implementations for the chain state service API. |
state/api/src/message.rs | Defines new StateRequest/StateResponse variants. |
state/api/src/lib.rs | Implements ChainStateAsyncService trait for service routing. |
state/api/Cargo.toml | Updates dependencies required by the API. |
account/src/account_storage.rs | Adjusts import order for DBStorage usage. |
account/Cargo.toml | Comments out an unused dependency to clean up configuration. |
Cargo.toml | Updates workspace members and dependency mappings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information