Skip to content

Support more services #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Support more services #4487

merged 2 commits into from
Apr 29, 2025

Conversation

simonjiao
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@simonjiao simonjiao requested review from welbon, nkysg and Copilot April 28, 2025 04:08
@simonjiao simonjiao requested a review from jolestar as a code owner April 28, 2025 04:08
Copy link

coderabbitai bot commented Apr 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@simonjiao simonjiao removed the request for review from jolestar April 28, 2025 04:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for additional services by implementing a new chain state service, extending the state API with asynchronous methods, and updating dependency management in Cargo.toml files.

  • Added a new ChainStateService implementation in the state/service module
  • Extended the state API with asynchronous service methods in state/api with corresponding message types
  • Updated workspace configuration and dependencies across multiple Cargo.toml files

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
state/service/src/service.rs Implements the ChainStateService with methods for state queries
state/service/src/lib.rs Exposes the ChainStateService
state/service/Cargo.toml Adds dependencies for state service
state/api/src/mock/* Adds mock implementations for the chain state API
state/api/src/message.rs Defines new message types for state service requests/responses
state/api/src/lib.rs Implements ChainStateAsyncService and integrates new response handling
account/src/account_storage.rs Minor update to use a different import order for RocksdbConfig
account/Cargo.toml Adjusts dependency comments
Cargo.toml Updates workspace members and dependency configurations

@nkysg nkysg requested review from Copilot and removed request for Copilot April 28, 2025 07:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new ChainStateService along with supporting API changes to enhance service support in the Starcoin ecosystem. Key changes include:

  • New implementation of ChainStateService and its integration via async and actor service interfaces in state/service.
  • Addition of state API endpoints and mock services in state/api to handle various state queries and proofs.
  • Updates to workspace configuration files (Cargo.toml) and minor adjustments in account module imports to align with the new changes.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
state/service/src/service.rs Introduces ChainStateService and its API implementation.
state/service/src/lib.rs Exports the new ChainStateService.
state/service/Cargo.toml Adds required dependencies for the new service functionality.
state/api/src/mock/mod.rs & mock_chain_state_service.rs Provides mock implementations for the chain state service API.
state/api/src/message.rs Defines new StateRequest/StateResponse variants.
state/api/src/lib.rs Implements ChainStateAsyncService trait for service routing.
state/api/Cargo.toml Updates dependencies required by the API.
account/src/account_storage.rs Adjusts import order for DBStorage usage.
account/Cargo.toml Comments out an unused dependency to clean up configuration.
Cargo.toml Updates workspace members and dependency mappings.

Copy link
Collaborator

@nkysg nkysg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkysg nkysg merged commit bf5ec6e into starcoin-vm2 Apr 29, 2025
3 of 5 checks passed
@nkysg nkysg deleted the support-chain-state-service branch April 29, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants