fix: handle community shard unassignment and update #4627
Merged
+166
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (10)
|
richard-ramos
force-pushed
the
fix/remove-shard
branch
2 times, most recently
from
49e1038 to
9d36709
Compare
There was a problem hiding this comment.
Reviewed only parts that are invoking Waku API.
Also, wondering if it is a good idea to just allow a community to switch a shard without some sort of migration warning. But this should be done at UI level i guess.
Also, it may be better to indicate the impact of doing this, as message history would be lost and any other such impact of changing shard.
richard-ramos
force-pushed
the
fix/remove-shard
branch
from
9d36709 to
d3265e5
Compare
igor-sirotin
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the issue described in status-im/status-desktop#13267