-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up biometrics and standard-auth and add tests #18756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9907438
to
8ccae9e
Compare
Jenkins BuildsClick to see older builds (68)
|
J-Son89
reviewed
Feb 8, 2024
src/status_im/common/standard_authentication/standard_auth/slide_button/view.cljs
Outdated
Show resolved
Hide resolved
ilmotta
reviewed
Feb 16, 2024
87498ce
to
4c45685
Compare
J-Son89
reviewed
Feb 19, 2024
J-Son89
reviewed
Feb 19, 2024
J-Son89
reviewed
Feb 19, 2024
J-Son89
reviewed
Feb 19, 2024
J-Son89
reviewed
Feb 19, 2024
J-Son89
reviewed
Feb 19, 2024
ilmotta
approved these changes
Feb 19, 2024
J-Son89
reviewed
Feb 20, 2024
J-Son89
approved these changes
Feb 20, 2024
Nice work @clauxx! 🚀 |
ajayesivan
approved these changes
Feb 21, 2024
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
96410c4
to
ee22298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18694
fixes #18847
Summary
Changes:
standard-auth/authorize
into (testable) eventsstandard-auth
eventsstandard-auth
eventsbiometric
events according to the guidelinebiometric
utils into their own nsbiometric
eventsbiometric
eventsPlatforms
Areas that maybe impacted
Functional
status: ready