Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up biometrics and standard-auth and add tests #18756

Merged
merged 30 commits into from
Mar 12, 2024

Conversation

clauxx
Copy link
Member

@clauxx clauxx commented Feb 7, 2024

fixes #18694
fixes #18847

Summary

Changes:

  • Refactored and split standard-auth/authorize into (testable) events
  • Added specs for standard-auth events
  • Added integration tests for standard-auth events
  • Refactored biometric events according to the guideline
  • Moved biometric utils into their own ns
  • Added specs for biometric events
  • Added unit tests for biometric events
  • Fixed bug which would show an error message if the user presses the biometric button multiple times very quickly (e.g. on the login screen)

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • login (with biometrics)
  • enable biometrics (from onboarding)
  • enable/disable biometrics (from settings)
  • anywhere biometrics is used
  • anywhere the "auth" slide-button is used

status: ready

@clauxx clauxx self-assigned this Feb 7, 2024
@clauxx clauxx force-pushed the cl-18694-biometrics-tests-schemas branch from 9907438 to 8ccae9e Compare February 7, 2024 22:35
@status-im-auto
Copy link
Member

status-im-auto commented Feb 7, 2024

Jenkins Builds

Click to see older builds (68)
Commit #️⃣ Finished (UTC) Duration Platform Result
8ccae9e #2 2024-02-07 22:35:50 ~14 sec android 📄log
8ccae9e #2 2024-02-07 22:36:15 ~38 sec android-e2e 📄log
8ccae9e #3 2024-02-07 22:36:22 ~7 sec android 📄log
✔️ 8ccae9e #2 2024-02-07 22:42:17 ~6 min ios 📱ipa 📲
bcf1c95 #3 2024-02-19 09:26:59 ~3 min tests 📄log
✔️ bcf1c95 #3 2024-02-19 09:31:11 ~8 min android-e2e 🤖apk 📲
✔️ bcf1c95 #4 2024-02-19 09:32:09 ~8 min android 🤖apk 📲
✔️ bcf1c95 #3 2024-02-19 09:32:46 ~9 min ios 📱ipa 📲
✔️ 18d97fa #4 2024-02-19 10:26:39 ~5 min tests 📄log
✔️ 18d97fa #4 2024-02-19 10:27:42 ~7 min ios 📱ipa 📲
✔️ 18d97fa #4 2024-02-19 10:29:33 ~8 min android-e2e 🤖apk 📲
✔️ 18d97fa #5 2024-02-19 10:29:41 ~9 min android 🤖apk 📲
✔️ 11af95c #5 2024-02-19 10:35:56 ~5 min tests 📄log
✔️ 11af95c #5 2024-02-19 10:37:10 ~6 min ios 📱ipa 📲
✔️ 11af95c #6 2024-02-19 10:38:21 ~7 min android 🤖apk 📲
✔️ 11af95c #5 2024-02-19 10:38:38 ~7 min android-e2e 🤖apk 📲
✔️ 3fa2426 #6 2024-02-19 12:18:07 ~4 min tests 📄log
✔️ 3fa2426 #6 2024-02-19 12:20:00 ~6 min ios 📱ipa 📲
✔️ 3fa2426 #6 2024-02-19 12:20:55 ~7 min android-e2e 🤖apk 📲
✔️ 3fa2426 #7 2024-02-19 12:20:58 ~7 min android 🤖apk 📲
✔️ cfd9e44 #7 2024-02-19 12:41:48 ~7 min tests 📄log
cfd9e44 #7 2024-02-19 12:42:09 ~7 min ios 📄log
✔️ cfd9e44 #7 2024-02-19 12:42:45 ~8 min android-e2e 🤖apk 📲
✔️ cfd9e44 #8 2024-02-19 12:42:53 ~8 min android 🤖apk 📲
✔️ 4c45685 #9 2024-02-19 13:09:24 ~5 min tests 📄log
✔️ 4c45685 #9 2024-02-19 13:10:28 ~6 min ios 📱ipa 📲
✔️ 4c45685 #9 2024-02-19 13:11:20 ~7 min android-e2e 🤖apk 📲
✔️ 4c45685 #10 2024-02-19 13:11:57 ~8 min android 🤖apk 📲
✔️ 41ca992 #10 2024-02-19 15:09:44 ~4 min tests 📄log
✔️ 41ca992 #10 2024-02-19 15:11:53 ~7 min ios 📱ipa 📲
✔️ 41ca992 #10 2024-02-19 15:12:37 ~7 min android-e2e 🤖apk 📲
✔️ 41ca992 #11 2024-02-19 15:12:45 ~7 min android 🤖apk 📲
✔️ f7d403d #12 2024-02-20 09:16:12 ~7 min android-e2e 🤖apk 📲
✔️ f7d403d #13 2024-02-20 09:16:31 ~7 min android 🤖apk 📲
✔️ f7d403d #12 2024-02-20 09:16:59 ~8 min ios 📱ipa 📲
✔️ e0297a9 #13 2024-02-20 09:24:05 ~6 min ios 📱ipa 📲
✔️ e0297a9 #13 2024-02-20 09:25:19 ~7 min android-e2e 🤖apk 📲
✔️ e0297a9 #14 2024-02-20 09:25:31 ~7 min android 🤖apk 📲
✔️ 16ae976 #16 2024-02-20 13:37:13 ~7 min android 🤖apk 📲
✔️ 16ae976 #15 2024-02-20 13:38:04 ~7 min android-e2e 🤖apk 📲
✔️ 16ae976 #15 2024-02-20 13:45:04 ~14 min ios 📱ipa 📲
✔️ 6026805 #16 2024-02-21 08:20:18 ~7 min ios 📱ipa 📲
✔️ 6026805 #16 2024-02-21 08:20:58 ~8 min android-e2e 🤖apk 📲
✔️ 6026805 #17 2024-02-21 08:21:03 ~8 min android 🤖apk 📲
✔️ bbdfeb4 #18 2024-02-21 09:10:32 ~5 min tests 📄log
✔️ bbdfeb4 #19 2024-02-21 09:12:14 ~6 min android 🤖apk 📲
✔️ bbdfeb4 #18 2024-02-21 09:12:25 ~6 min ios 📱ipa 📲
✔️ bbdfeb4 #18 2024-02-21 09:12:34 ~7 min android-e2e 🤖apk 📲
✔️ 2b13f08 #19 2024-02-21 13:56:31 ~6 min tests 📄log
✔️ 2b13f08 #19 2024-02-21 13:57:28 ~7 min ios 📱ipa 📲
✔️ 2b13f08 #19 2024-02-21 13:59:06 ~9 min android-e2e 🤖apk 📲
✔️ 2b13f08 #20 2024-02-21 13:59:15 ~9 min android 🤖apk 📲
✔️ 1d40984 #20 2024-03-04 09:37:45 ~6 min tests 📄log
✔️ 1d40984 #21 2024-03-04 09:38:17 ~7 min android 🤖apk 📲
✔️ 1d40984 #20 2024-03-04 09:38:27 ~7 min android-e2e 🤖apk 📲
✔️ 1d40984 #20 2024-03-04 09:43:15 ~12 min ios 📱ipa 📲
✔️ fe10704 #21 2024-03-05 16:48:56 ~6 min tests 📄log
✔️ fe10704 #21 2024-03-05 16:49:15 ~6 min android-e2e 🤖apk 📲
✔️ fe10704 #21 2024-03-05 16:50:04 ~7 min ios 📱ipa 📲
✔️ fe10704 #22 2024-03-05 16:50:06 ~7 min android 🤖apk 📲
✔️ 255f3a4 #23 2024-03-11 09:23:22 ~7 min android-e2e 🤖apk 📲
✔️ 255f3a4 #24 2024-03-11 09:23:27 ~7 min android 🤖apk 📲
✔️ 255f3a4 #23 2024-03-11 09:24:00 ~7 min ios 📱ipa 📲
✔️ 255f3a4 #24 2024-03-11 09:50:04 ~4 min tests 📄log
✔️ d121aec #25 2024-03-11 10:28:16 ~5 min tests 📄log
✔️ d121aec #25 2024-03-11 10:29:25 ~7 min android 🤖apk 📲
✔️ d121aec #24 2024-03-11 10:30:04 ~7 min android-e2e 🤖apk 📲
✔️ d121aec #24 2024-03-11 10:30:46 ~8 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 96410c4 #26 2024-03-12 09:46:46 ~5 min tests 📄log
✔️ 96410c4 #25 2024-03-12 09:47:45 ~6 min android-e2e 🤖apk 📲
✔️ 96410c4 #26 2024-03-12 09:48:34 ~7 min android 🤖apk 📲
✔️ 96410c4 #25 2024-03-12 09:48:40 ~7 min ios 📱ipa 📲
✔️ ee22298 #27 2024-03-12 10:12:14 ~5 min tests 📄log
✔️ ee22298 #26 2024-03-12 10:14:10 ~7 min android-e2e 🤖apk 📲
✔️ ee22298 #27 2024-03-12 10:14:11 ~7 min android 🤖apk 📲
✔️ ee22298 #26 2024-03-12 10:14:17 ~7 min ios 📱ipa 📲

@clauxx clauxx force-pushed the cl-18694-biometrics-tests-schemas branch from 87498ce to 4c45685 Compare February 19, 2024 13:03
@J-Son89
Copy link
Contributor

J-Son89 commented Feb 20, 2024

Nice work @clauxx! 🚀

clauxx added 27 commits March 12, 2024 11:59
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
@clauxx clauxx force-pushed the cl-18694-biometrics-tests-schemas branch from 96410c4 to ee22298 Compare March 12, 2024 10:06
@clauxx clauxx merged commit 637efa2 into develop Mar 12, 2024
6 checks passed
@clauxx clauxx deleted the cl-18694-biometrics-tests-schemas branch March 12, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
7 participants