Wallet: Password field contains saved data once user put it before while transaction confirmation #18447 #18899
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ | |
| [utils.debounce :as debounce] | ||
| [utils.i18n :as i18n] | ||
| [utils.re-frame :as rf] | ||
| [utils.security.core :as security] | ||
| [utils.transforms :as transforms])) | ||
|
|
||
| (defonce push-animation-fn-atom (atom nil)) | ||
|
|
@@ -190,56 +191,81 @@ | |
| :default-password password}])) | ||
|
|
||
| (defn login-section | ||
| [] | ||
| (let [password-value (reagent/atom nil)] | ||
| (fn [{:keys [set-show-profiles]}] | ||
| (let [{:keys [processing password]} (rf/sub [:profile/login]) | ||
| {:keys [key-uid name customization-color]} (rf/sub [:profile/login-profile]) | ||
| sign-in-enabled? (rf/sub [:sign-in-enabled?]) | ||
| profile-picture (rf/sub [:profile/login-profiles-picture key-uid]) | ||
| auth-method (rf/sub [:auth-method]) | ||
| login-multiaccount #(rf/dispatch [:profile.login/login]) | ||
| on-change-password (fn [value] | ||
| (reset! password-value value) | ||
| (when (not= value | ||
| (security/safe-unmask-data | ||
| password)) | ||
| (rf/dispatch [:set-in | ||
|
There was a problem hiding this comment. These type of events status-mobile/src/legacy/status_im/events.cljs Lines 220 to 222 in bfed36d There was a problem hiding this comment. They are still being used here @mmilad75. Maybe you forgot to push? |
||
| [:profile/login :password] | ||
| (security/mask-data value)]) | ||
| (rf/dispatch [:set-in [:profile/login :error] | ||
| ""])))] | ||
| [rn/keyboard-avoiding-view | ||
| {:style style/login-container | ||
| :keyboardVerticalOffset (- (safe-area/get-bottom))} | ||
| [rn/view | ||
| {:style style/multi-profile-button-container} | ||
| (when config/quo-preview-enabled? | ||
| [quo/button | ||
| {:size 32 | ||
| :type :grey | ||
| :background :blur | ||
| :icon-only? true | ||
| :on-press #(rf/dispatch [:navigate-to :quo-preview]) | ||
| :disabled? processing | ||
| :accessibility-label :quo-preview | ||
| :container-style {:margin-right 12}} | ||
| :i/reveal-whitelist]) | ||
| [quo/button | ||
| {:size 32 | ||
| :type :grey | ||
| :background :blur | ||
| :icon-only? true | ||
| :on-press set-show-profiles | ||
| :disabled? processing | ||
| :accessibility-label :show-profiles} | ||
| :i/multi-profile]] | ||
| [rn/scroll-view | ||
| {:keyboard-should-persist-taps :always | ||
| :style {:flex 1}} | ||
| [quo/profile-card | ||
| {:name name | ||
| :customization-color (or customization-color :primary) | ||
| :profile-picture profile-picture | ||
| :card-style style/login-profile-card}] | ||
| [standard-authentication/password-input | ||
| {:shell? true | ||
| :blur? true | ||
| :on-press-biometrics (when (= auth-method constants/auth-method-biometric) | ||
| (fn [] | ||
| (rf/dispatch [:biometric/authenticate | ||
| {:on-success #(rf/dispatch | ||
| [:profile.login/biometric-success]) | ||
| :on-fail #(rf/dispatch | ||
| [:profile.login/biometric-auth-fail | ||
| %])}]))) | ||
| :password @password-value | ||
| :on-change-password on-change-password}]] | ||
| [quo/button | ||
| {:size 40 | ||
| :type :primary | ||
| :customization-color (or customization-color :primary) | ||
| :accessibility-label :login-button | ||
| :icon-left :i/unlocked | ||
| :disabled? (or (not sign-in-enabled?) processing) | ||
| :on-press login-multiaccount | ||
| :container-style {:margin-bottom (+ (safe-area/get-bottom) 12)}} | ||
| (i18n/label :t/log-in)]])))) | ||
|
|
||
| ;; we had to register it here, because of hotreload, overwise on hotreload it will be reseted | ||
| (defonce show-profiles? (reagent/atom false)) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are talking more about performance these days, I'd like to mention a few things for this
enter-passwordcomponent I deem significant and that appear in many of our PRs. In no order of importance::standard-auth/update-passwordon every key press, this forces the parentviewcomponent to be rendered twice, for every key press. This problem cascades to its childrenpassword-input/viewandquo/button.input/viewitself is quite heavy. We can save a bunch of CPU cycles if we process the parentviewcomponent and its children only once on every key press.buttoncomponent are different on every Reagent pass because theon-pressfunction is recreated over and over. This forces the button component to be re-processed by Reagent on every pass of the parent component.Things that would allow us to render all components in
enter-passwordonce on every key press:[:profile/login :password]and[:profile/login :error]on every key press. Use local state and then the wholeenter-passwordcomponent and its children would render once. The global state should be left for things that change less often.key-uiddoesn't change when the user is typing, so it can be moved outside the renderer, and then we can make theon-pressof the button be created only once. This would allow Reagent to skip processing the button component entirely on every key press. The button component is not the cheapest too if we look at its implementation.cc @flexsurfer A slightly different example than what we were discussing today in the perf channel. Still, a good example where multiple Reagent passes cascade down the component tree (and I haven't checked the other subcomponents, but on the surface they also have low-hanging fruits to optimize).