Skip to content

Logic for multiple subs #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

agreedSkiing
Copy link
Contributor

@agreedSkiing agreedSkiing commented Dec 15, 2024

Fix for #225

Might also fix #229

Test only on these svt videos

with Firefox developer-edition Mozilla Firefox 134.0b1 and ffmpeg version n7.1 on Manjaro Linux.

Built the plugin with npm 10.9.0 and node 22.10.0.

@stefansundin
Copy link
Owner

Hello. Unfortunately I didn't see this PR until now. I'll try to look at it later. Thank you.

@agreedSkiing
Copy link
Contributor Author

No problemo @stefansundin, want me to rebase the branch?

@stefansundin
Copy link
Owner

Yes, please. Thank you.

And you can drop the bootstrap change. 👍

@agreedSkiing agreedSkiing force-pushed the feat/logic-for-multiple-subs branch from c9f5172 to 99576db Compare February 25, 2025 20:32
@agreedSkiing
Copy link
Contributor Author

@stefansundin done and done, also fixed the formatting to look like it did before

@stefansundin stefansundin merged commit a9e1430 into stefansundin:main Feb 26, 2025
@stefansundin
Copy link
Owner

Efter lite testning så ändrade jag på koden, se 11104c8 och 8befa74.

Skälen står beskrivna i commit meddelandena, men resultatet är att jag i princip bara behållit argumentet -c:s mov_text och tagit bort -map helt. Tills ett bättre UI är byggt för att välja video, ljud, och undertexter separat så får det här duga.

@agreedSkiing
Copy link
Contributor Author

agreedSkiing commented Feb 27, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtitles on tv4
2 participants