rustfmt ignore deprecated

[austinabell]

Now in Rust 1.44, the

#![cfg_attr(rustfmt, rustfmt_skip)]

tags are now deprecated in favour of #![rustfmt::skip], I tried to replace the tags but for some reason it doesn't work with the autogen code, and I didn't dig deeper.

To replicate, I think it's just sufficient when updating to 1.44 and run a cargo fmt and it will format all autogen files in this repo or otherwise.

[Elrendio]

See rust-lang/rust#73078 to see why #![rustfmt::skip] doesn't work.

In short: it's a bug in rustfmt, should be fixed asap. I think it's best to migrate to #![rustfmt::skip] and wait for rustfmt to fix their bug rather than add #[rustfmt::skip] on all items on the generated code.

[hds]

The change in PR #495 breaks compilation of protobuf 2.15 (at least for me). I know the error is in rustfmt, but until it's fixed, perhaps a more conservative approach could be taken?

The PR mentions that this issue should be fixed in 1.44.1, but so far I see the same behaviour adding the two tags to the default example in the Rust playground:

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=392753339f4652381c92297a5831c8a4

Would it be acceptable to revert to the original tag (as in 2.14)?

[stepancheg]

@hds can you please provide full example, which does not work?

AFAIU,

#![allow(unused_attributes)]
#![rustfmt::skip] 

does not work in root module, but works fine in other modules.

[stepancheg]

Just in case, this file is committed to the repostory, it compiles just fine.

[stepancheg]

... it is tested with Rust 1.44.1.

[dvc94ch]

Same here, it works locally, but breaks ci build. Very strange. If I could only reproduce this locally, it just works no matter what I try...

  |
9 | #![rustfmt::skip]
  | ^^^^^^^^^^^^^^^^^
  |
  = note: for more information, see https://github.com/rust-lang/rust/issues/54726
  = help: add `#![feature(custom_inner_attributes)]` to the crate attributes to enable

error[E0658]: non-builtin inner attributes are unstable
 --> /home/runner/.cargo/registry/src/github.lhy31512.workers.dev-1ecc6299db9ec823/protobuf-2.15.1/src/well_known_types/wrappers.rs:9:1
  |
9 | #![rustfmt::skip]
  | ^^^^^^^^^^^^^^^^^
  |
  = note: for more information, see https://github.com/rust-lang/rust/issues/54726
  = help: add `#![feature(custom_inner_attributes)]` to the crate attributes to enable

   Compiling rand_hc v0.1.0
   Compiling rand_isaac v0.1.1
   Compiling rand_xorshift v0.1.1
error: aborting due to 13 previous errors

For more information about this error, try `rustc --explain E0658`.
error: could not compile `protobuf`.
warning: build failed, waiting for other jobs to finish...
error: build failed
##[error]Process completed with exit code 101.
  Complete job

full log here: https://github.com/sunshine-protocol/sunshine-bounty/pull/106/checks?check_run_id=820586662

[stepancheg]

@dvc94ch your logs say all jobs install rust nightly-2020-02-05, which is quite old.

[stepancheg]

... even stable jobs seems to install the same nightly.

[stepancheg]

Yep,

[dvc94ch]

Thanks, that was indeed the problem

[Xaeroxe]

Protobuf 2.15 isn't compiling for rust 1.43 oddly. Protobuf 2.14 does compile using the same compiler.

[stepancheg]

@Xaeroxe it is compatible with Rust mininum version 1.44.1, it is documented in changelog.

Unfortunately, rust-protobuf dependency on rustfmt macros and clippy make it very hard to make the library compatible with a wide range of rust compiler versions.

Life would be much easier if rustfmt supported comment markers, not just rust attributes. And @generated sounds like a great option for me. Add a like to this issue: rust-lang/rustfmt#3958.

[hds]

@hds can you please provide full example, which does not work?

AFAIU,

#![allow(unused_attributes)]
#![rustfmt::skip] 

does not work in root module, but works fine in other modules.

I retested locally ensuring 1.44.1 and you are right, it does compile fine outside of the root module.