build error on #![rustfmt::skip]

[dwarburt]

Today I had a build error while trying to build the brave browser

   Compiling semver-parser v0.10.1
error[E0658]: non-builtin inner attributes are unstable
 --> /home/david/git/fork/brave-browser/src/brave/build/rustup/0.1.4/registry/src/github.lhy31512.workers.dev-1ecc6299db9ec823/semver-parser-0.10.1/src/generated.rs:4:1
  |
4 | #![rustfmt::skip]
  | ^^^^^^^^^^^^^^^^^
  |
  = note: see issue #54726 <https://github.com/rust-lang/rust/issues/54726> for more information

   Compiling tracing-log v0.1.1
error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.
error: could not compile `semver-parser`.

It seems like that comes from this line:

semver-parser/tests/genpest.rs

Line 17 in 4ad3c7b

#![rustfmt::skip]

but in order to get it to build I had to delete this line

semver-parser/src/generated.rs

Line 4 in 4ad3c7b

#![rustfmt::skip]

from my local working copy, and after that it builds fine.

[steveklabnik]

dtolnay/semver#218 is the same issue in another crate.

This is very strange...

[kentfredric]

My analysis indicates that that syntax only started being legal in rust 1.44.

I can build semver-parser 0.10.1 on all rusts newer than 1.44, but all older ones fail.

So to me it looks like, the only regression here is the one added in 0.10.1 with 9e01cd3

https://kentfredric.github.io/rust-vmatrix/#crate-s

https://kentfredric.github.io/rust-vmatrix/semver-parser/

[steveklabnik]

Whelp, I did not know this, and thought it was used previously. Sorry about the noise.

[djc]

Not sure why this was closed? #54 fixes it and sets up MSRV testing in CI.

[steveklabnik]

I thought this was the ticket in rust-lang/rust 😅😓

[j-maas]

For those running into this error message: Check that you are not running an older version of Rust by executing rustup update.

[steveklabnik]

This should be fixed in 0.10.2.