Dockerize #40
Merged
Dockerize #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2024 11:24
… args to epomaker-controller within container
|
NB the container version does not work with the GUI or with uploading images, that will take some more work |
strodgers
added a commit
that referenced
this pull request
Sep 26, 2024
* Add docker and compose file. Dont need sudo if already root * Docker image only creates udev rules if it needs to, then just passes args to epomaker-controller within container
strodgers
added a commit
that referenced
this pull request
Sep 27, 2024
* feat: Adds key mapping command. * Update README.md * Break out some utils, ensure device is closed every time * Use config files for the GUI keyboard layout (#38) * Use config files for the GUI keyboard layout * Update docstring * Dockerize (#40) * Add docker and compose file. Dont need sudo if already root * Docker image only creates udev rules if it needs to, then just passes args to epomaker-controller within container * Add signal handling to make sure device is closed * Bump version * Move delays inside send-cpu/temp. Dont bother with temp if its not set. Put the prints back in * Better printout when setting key rgb * Fix bug where daemon test mode can send 100 (must be 0-99) * Fix linting errors * Keymaps config file (#39) * Add config files for keymaps (not finished yet) * Finish adding config files for keymaps, including a config.py with some helper classes. * A few more places needed updating to use config files. Add a few more comments here and there * Delete commented out code * pkg_resources.path isnt a string, need to open it and get the path str * unused import * unused code * tidy up imports * Make display_str optional for KeyboardKey * Missing import after merge with main. Remove unparsed configs in layout json (a) --------- Co-authored-by: Sam Rodgers <[email protected]> * Use a config file for some of the controller settings (#42) * Integrate cskau's keymapping command into main * Add cli command to print keymap config * Update docstring * Keep KeyboardKey frozen --------- Co-authored-by: Clement Skau <[email protected]> Co-authored-by: Sam Rodgers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Dockerfile and a compose file to use the application containerized.
The Dockerfile copies the source and installs it using pip. Then a nonrootuser is created for running the application later on.
I am using an entrypoint.sh script so that the container runs
epomakercontroller --dev udevwhen it starts up, then drops down to the nonrootuser passing any cli args along toepomakercontroller.To get the udev rules to work I had to mount /run/udev in the compose file, which I don't love doing since I quite want the container to be isolated, however I'd prefer to run
epomakercontrolleras non-root, which requires udev rules, which requires mounting /run/udev.I am not sure how this would ever work with uploading an image but I'll look into that. I am mostly hoping to use this with users who are experiencing problems so we can rule out environment to some extent.
Use compose to build it:
docker compose buildThen run with some commands using compose run:
docker compose run epomaker-controller <some commands>eg
docker compose run --rm epomaker-controller send-cpu 56