fix failing tests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rmg
commented
Apr 13, 2017
•
rmg
commented
- Fixes a port collision with Cassandra on our primary CI
- Fixes an instance of zlib different on OSX and Linux in newest releases nodejs/node#12244 that only shows up on macOS
- adds Travis config so that Travis knows this isn't a Ruby gem
The problem is that gzip headers include a platform identifier. Previously, zlib was incorrectly treating macOS as just a "generic UNIX", but now it is actually using the correct header. The updated zlib made its way in to recent versions of node and started uncovering a new source of platform-specific assumptions that people didn't know they were making. To fix this, instead of hard-coding the expected gzip compression result, we can just generate them on the testing platform. This is an instance of nodejs/node#12244. Signed-off-by: Ryan Graham <[email protected]>
Signed-off-by: Ryan Graham <[email protected]>
|
LGTM! |
Port 7000 and 7001 are used by Cassandra, which is present and running in our primary test environments on CI. Signed-off-by: Ryan Graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.