Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics-informed neural networks for data-driven fluid model #2444

Open
wants to merge 70 commits into
base: develop
Choose a base branch
from

Conversation

EvertBunschoten
Copy link
Member

@EvertBunschoten EvertBunschoten commented Feb 14, 2025

Proposed Changes

The data-driven fluid model in SU2 has been upgraded with the ability to use physics-informed neural networks (PINN's) to compute the fluid thermodynamic state for NICFD flows. This functionality was presented during the 2024 SU2 conference and the issues regarding non-physical behavior have been addressed.

The use of PINN makes the data-driven fluid model substantially more robust and efficient for flow and adjoint simulations of flows of fluids in the non-ideal thermodynamic state.

PINN's can be trained using SU2 DataMiner for any fluid or compatible mixture of fluids available in the CoolProp library. An elaborate tutorial integrating SU2 DataMiner with the data-driven fluid solver in SU2 will follow soon!

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pcarruscag
Copy link
Member

LGTM but @joshkellyjak should approve because I expect the way the merge and unmerge with the turbo ramp branch was done is going to create either conflicts or silently revert the work in that branch.

@joshkellyjak
Copy link
Contributor

LGTM but @joshkellyjak should approve because I expect the way the merge and unmerge with the turbo ramp branch was done is going to create either conflicts or silently revert the work in that branch.

I'm happy to approve this and then update in turbo ramps branch. Still having the same regression test issue and couldn't find a solution. Probably easier to merge this and then fix on my side.

Density = rho;
StaticEnergy = e;
Enthalpy = e + Pressure / rho;
Temperature = pow(dsde_rho, -1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a good oppurtunity to apply @oleburghardt 's tagging tool in #2343 , should dsde_rho be declared as an input to the preaccumlation region?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants