Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viscous ionization test cases. #116

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Viscous ionization test cases. #116

merged 4 commits into from
Feb 21, 2023

Conversation

WallyMaier
Copy link
Contributor

@WallyMaier WallyMaier commented Jan 24, 2023 •
edited
Loading

This directly relates to PR #1887

Includes a restarted viscous cylinder (Air-7) using the Gupta-Yos transport model.

@bigfooted
Copy link
Contributor

Fine by me!

bigfooted
bigfooted approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@bigfooted bigfooted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure that the reference to the changed filename is changed in the SU2 PR as well.

@pcarruscag
Copy link
Member

Use squash merge when you merge this.

@WallyMaier WallyMaier merged commit 47d2ebc into develop Feb 21, 2023
@WallyMaier WallyMaier deleted the feature_NEMO_visc_ion branch February 21, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigfooted bigfooted bigfooted approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WallyMaier @bigfooted @pcarruscag