-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Git Formats] Diff TOC components for renames #4196
Open
michaelblyons
wants to merge
3
commits into
sublimehq:master
Choose a base branch
from
michaelblyons:git/diff/toc-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Git Formats] Diff TOC components for renames #4196
michaelblyons
wants to merge
3
commits into
sublimehq:master
from
michaelblyons:git/diff/toc-changes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b7d37b
to
1f6bf7f
Compare
Branching would also be an option. Maybe not worth it. |
deathaxe
reviewed
Mar 28, 2025
I am fine with not pushing contexts for braces. |
Co-authored-by: deathaxe <[email protected]>
deathaxe
previously approved these changes
Mar 28, 2025
michaelblyons
commented
Mar 28, 2025
deathaxe
approved these changes
Mar 30, 2025
jrappen
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scopes to some additional sections of the rename/move/copy format.
If the community determines that it's worth it to forward-lookahead open/close brace pairs, I can do that. But sometimes they are not matched, as in the example test.