Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

feat(usepageviewtrigger): add support for custom parameters #209

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

voronianski
Copy link
Member

Purpose

In certain cases there is a necessity to send additional parameters in page-view event (e.g. integration with cookie consent providers or additional marketing data, etc.). Right now it's not possible, thus opening this PR.

Approach & changes

  • add optional dispatchParams argument into usePageViewTrigger hook
  • add necessary unit + update existing page view tests approach to be inline with documentation

@sumup-clark
Copy link

sumup-clark bot commented Dec 1, 2021

Hey @voronianski,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @voronianski!

@voronianski voronianski merged commit 9514e30 into main Dec 1, 2021
@voronianski voronianski deleted the feature/custom-params-in-page-view branch December 1, 2021 14:50
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants