Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-formatter-github - allows manipulating the GitHub action check and view metadata #827

Closed
waigel opened this issue Mar 22, 2023 · 2 comments · Fixed by #828
Closed

Comments

@waigel
Copy link
Contributor

waigel commented Mar 22, 2023

You use the library (eslint-formatter-github) in several repositories, which has a hard-coded private key to the authorized GitHub app in the source code. This is a possible security vulnerability. The certificate gives every user read/write permissions to your GitHub actions check. In addition, metadata from non-public repositories can also be viewed.

Attached is a list of all the repositories that you have granted access:

sumup-oss/.github
sumup-oss/assets
sumup-oss/basic-project
sumup-oss/circuit-ui
sumup-oss/collector
sumup-oss/design-tokens
sumup-oss/foundry
sumup-oss/go-pkgs
sumup-oss/gocat
sumup-oss/icons
sumup-oss/intl-js
sumup-oss/janos
sumup-oss/ot
sumup-oss/performance-observer
sumup-oss/signal
sumup-oss/simeon
sumup-oss/terraform-provider-vaulted
sumup-oss/terraform-provider-vaulted-tfe
sumup-oss/vaulted
sumup-oss/website

sumup/circuit-ui-form
sumup/documentation
sumup/invoices-email-template
sumup/invoices-onboarding-api
sumup/user-tracking
sumup/ze-dashboard

Source: https://github.com/hipstersmoothie/eslint-formatter-github/blob/master/src/create-check.ts#L20

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 5.2.0-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@connor-baer
Copy link
Member

connor-baer commented Apr 17, 2023

The vulnerable dependencies have been removed in https://github.com/sumup-oss/foundry/releases/tag/v6.0.0. Thank you, @waigel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants