Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

fix: remove lint:ci and change lint task on ci.yml to not use GH formatter #338

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

pdrmdrs
Copy link
Contributor

@pdrmdrs pdrmdrs commented Apr 4, 2023

Relates to sumup-oss/foundry#827.

Purpose

You use the library (eslint-formatter-github) in several repositories, which has a hard-coded private key to the authorized GitHub app in the source code. This is a possible security vulnerability. The certificate gives every user read/write permissions to your GitHub actions check. In addition, metadata from non-public repositories can also be viewed.

Approach and changes

  • Stop using eslint-formatter-github and revoke access to the repository

@pdrmdrs pdrmdrs requested a review from a team as a code owner April 4, 2023 12:52
@pdrmdrs pdrmdrs self-assigned this Apr 4, 2023
@pdrmdrs pdrmdrs requested review from connor-baer and removed request for a team April 4, 2023 12:52
@sumup-clark
Copy link

sumup-clark bot commented Apr 4, 2023

Hey @pdrmdrs,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@connor-baer connor-baer merged commit 85460b9 into main Apr 4, 2023
@connor-baer connor-baer deleted the fix/remove-github-formatter branch April 4, 2023 13:07
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Published to NPM label Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Published to NPM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants