add support for latest nightly with generator resume arguments #2
+21
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for this PR! Unfortunately, I'm not sure what to do about it. Firstly, this whole crate is going to be deprecated soon with rust-lang/rust#69033. Secondly, this crate is used by some projects that pin their compilers to a specific nightly, so upgrading to a new nightly is going to be a breaking change for those projects. I guess I could release this as a new major version of core-futures-tls. I'd add the nightly coverage of each versions in the README. Or, we could use something like https://docs.rs/version_check/ to select between implementations based on the nightly version. |
|
rust-lang/rust#69033 was merged. Next nightly will support it, and as such core-futures-tls will lose its reason for being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i also ran cargo fmt