-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: flesh out icons section and make standalone page #13555
Conversation
|
Any chance you could touch on what icon libraries we should prefer then? i.e. what is the best strategy for releasing icon libraries in svelte. Just the aforementioned CSS? |
I really like the CSS approach. I don't necessarily want to favor one library over another, but if you want an example of one that is easier to compile you can see the approach taken by https://github.com/RobBrazier/svelte-awesome which has only a few |
Interesting, from https://iconify.design/docs/usage/css/:
It seems that this approach generally doesn't support tree shaking etc? So you pay for all the icons if you use just a few? Or you can do something like in RobBrazier/svelte-awesome but man from a quick look through that looks messy 😅 A shame .svelte files are discouraged/don't play nicely with vite. It's definitely the most intuitive approach. |
That's not true. I'm not sure why they've written it. I filed an issue to ask about it: iconify/iconify#367 |
Co-authored-by: Tee Ming <[email protected]>
I think this fits better as a separate page and is more discoverable. It doesn't really make sense to talk about CSS-based icons on the images page and none of these get optimized.
I had wanted to make this a separate page originally, but didn't have enough content. I added some more to it, so that it looks decent as its own page now. I tested locally to ensure it renders nicely