Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demos in /example are outdated #165

Closed
syvb opened this issue Jan 17, 2021 · 7 comments · Fixed by #195
Closed

Demos in /example are outdated #165

syvb opened this issue Jan 17, 2021 · 7 comments · Fixed by #195

Comments

@syvb
Copy link
Contributor

syvb commented Jan 17, 2021

The examples in /example are using 1.0.0. They should be updated to the current release.

@non25
Copy link
Contributor

non25 commented Jan 18, 2021

I think it is better to just delete them and make https://github.com/sveltejs/template-webpack a good place to start instead.
I was thinking about making branches with examples for different usecases.
css frameworks, babel, etc.
So users could see what are the steps to do something in particular.

@kyrylkov
Copy link

@Smittyvb @non25 Is this the only issue preventing v3 from getting released?

@syvb
Copy link
Contributor Author

syvb commented Jan 21, 2021

@kyrylkov This issue can wait until 3.0.0 is released, and probably should in case there are any more last minute changes.

@kyrylkov
Copy link

@Smittyvb So what are the current blockers for v3 release?

@syvb
Copy link
Contributor Author

syvb commented Jan 21, 2021

@kyrylkov Potentially #164, but it appears it would be fine to release without it. So nothing.

@kyrylkov
Copy link

kyrylkov commented Jan 21, 2021

@Smittyvb I see, OK. The reason I'm asking is that we've been successfully using master branch in production, but it would be better to revert to regular npm versioning. So for our specific use case, it's stable enough for v3 release.

@syvb
Copy link
Contributor Author

syvb commented Jan 21, 2021

@Conduitry given that you published the last version to NPM, could you tag+publish this? (make sure to remove (unreleased) from CHANGELOG.md)

dummdidumm added a commit that referenced this issue Jun 2, 2022
These examples are very outdated, and require a very old version of svelte-loader and Svelte to be used. This removes them to avoid confusion. Fixes #165.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants