Allow any version of svelte greater than 1.44.0 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's ugly warnings in sapper because svelte-loader believes it is incompatible with sapper 2. It does not appear to be _at all_ incompatible with v2 though. The problem is that there are really two versions to keep track of in svelte: 1. The compiler API. (The part that matters for svelte-loader) 2. The svelte language itself. (The part that got svelte bumped to v2). Both are interesting. Both need to be tracked. But they should probably be tracked in separate packages to allow more specific dependencies. (So, for example, you could lock into the compiler API at `^1.44.0` but the language at '2.x').
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's ugly warnings in sapper because svelte-loader believes it is incompatible with sapper 2. It does not appear to be at all incompatible with v2 though. Currently I'm ignoring the irritating warning.
The problem is that there are really two versions to keep track of in svelte:
Both are interesting. Both need to be tracked. But they should probably be tracked in separate packages to allow more specific dependencies. (So, for example, you could lock into the compiler API at
^1.44.0but the language at '2.x').